From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29416 invoked by alias); 5 Jun 2014 19:30:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29403 invoked by uid 89); 5 Jun 2014 19:30:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 19:30:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55JUjaB019116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 5 Jun 2014 15:30:46 -0400 Received: from tucnak.zalov.cz (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s55JUhxK010850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jun 2014 15:30:45 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s55JUfSC022232; Thu, 5 Jun 2014 21:30:42 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s55JUdYE022231; Thu, 5 Jun 2014 21:30:39 +0200 Date: Thu, 05 Jun 2014 19:30:00 -0000 From: Jakub Jelinek To: Jeff Law Cc: Tom Tromey , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 4/5] add gcc/gdb interface files Message-ID: <20140605193039.GI10386@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1400254001-12038-1-git-send-email-tromey@redhat.com> <1400254001-12038-5-git-send-email-tromey@redhat.com> <537DF2F5.4030009@redhat.com> <20140522131635.GE10386@tucnak.redhat.com> <874n009zpa.fsf@fleche.redhat.com> <5390C3B9.5090807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5390C3B9.5090807@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00512.txt.bz2 On Thu, Jun 05, 2014 at 01:23:37PM -0600, Jeff Law wrote: > >>>+GCC_METHOD7 (gcc_decl, build_decl, > >>>+ const char */* name */, > >>>+ enum gcc_c_symbol_kind /* sym_kind */, > >>>+ gcc_type /* sym_type */, > >>>+ const char */* substitution_name */, > >>>+ gcc_address /* address */, > >>>+ const char */* filename */, > >>>+ unsigned int /* line_number */) > > [ OK, not entirely true, when looking at diffs a trailing whitespace > gets colorized, so I tend not to have those leak through in my own > patches anymore. ] Another possibility would be to give the macros twice as many arguments as there are parameters and just through the odd arguments away when expanding to the template parameters. That would mean you write GCC_METHOD7 (gcc_decl, build_decl, const char *, name, enum gcc_c_symbol_kind, sym_kind, const char *, substitution_name, gcc_address, address, const char *, filename, unsigned int, line_number); though it isn't very nice either, guess I'm bikeshedding... ;) Jakub