From: Martin Jambor <mjambor@suse.cz>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 4/7] Break up determine_known_aggregate_parts
Date: Fri, 06 Jun 2014 13:28:00 -0000 [thread overview]
Message-ID: <20140606132828.GA29831@virgil.suse> (raw)
In-Reply-To: <20140526005417.GA15226@kam.mff.cuni.cz>
On Mon, May 26, 2014 at 02:54:17AM +0200, Jan Hubicka wrote:
> > Hi,
> >
> > the main purpose of this patch is to break up function
> > determine_known_aggregate_parts so that the next patch can use the
> > standalone bits and to make the changes slightly easier for review.
> >
> > However, this patch also removes some of the offset checks which Honza
> > correctly thought superfluous and even possibly filtering out useful
> > information.
> >
> > Bootstrapped and tested and LTO-bootstrapped on x86_64-linux.
> > OK for trunk after the preceeding patches get in?
> >
> > Thanks,
> >
> > Martin
> >
> >
> > 2014-02-19 Martin Jambor <mjambor@suse.cz>
> >
> > * ipa-prop.c (get_place_in_agg_contents_list): New function.
> > (build_agg_jump_func_from_list): Likewise.
> > (determine_known_aggregate_parts): Renamed to
> > determine_locally_known_aggregate_parts. Moved some functionality
> > to the two functions above, removed bound checks.
>
> This is OK.
> Does it depend on part 4?
>
No, it does not. I have re-tested the new order of the patches and
committed this one.
Thanks,
Martin
next prev parent reply other threads:[~2014-06-06 13:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 13:31 [PATCH 0/7] ipa-prop escape analysis Martin Jambor
2014-05-21 13:31 ` [PATCH 1/7] Add missing documentation of four IPA-CP params Martin Jambor
2014-05-21 15:58 ` Jeff Law
2014-06-10 12:13 ` Gerald Pfeifer
2014-06-29 23:07 ` Gerald Pfeifer
2014-07-15 12:01 ` Martin Jambor
2014-05-21 13:31 ` [PATCH 5/7] Advanced aggregate jump function construction Martin Jambor
2014-05-21 13:31 ` [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags Martin Jambor
2014-05-21 14:27 ` Richard Biener
2014-05-22 12:49 ` Martin Jambor
2014-05-22 13:34 ` Richard Biener
2014-05-22 15:24 ` Jan Hubicka
2014-05-22 15:36 ` Richard Biener
2014-05-22 18:11 ` Jan Hubicka
2014-05-23 10:03 ` Richard Biener
2014-05-23 22:29 ` Jan Hubicka
2014-05-24 7:39 ` Jan Hubicka
2014-05-26 13:03 ` Rainer Orth
2014-05-27 17:51 ` Jan Hubicka
2014-05-27 18:16 ` Rainer Orth
2014-05-26 1:01 ` Jan Hubicka
2014-05-21 13:31 ` [PATCH 4/7] Break up determine_known_aggregate_parts Martin Jambor
2014-05-26 0:54 ` Jan Hubicka
2014-06-06 13:28 ` Martin Jambor [this message]
2014-05-21 13:31 ` [PATCH 3/7] IPA-CP escape and clobber analysis Martin Jambor
2014-05-21 14:51 ` Richard Biener
2014-05-23 14:50 ` Martin Jambor
2014-05-21 13:31 ` [PATCH 2/7] Analyze BBs in DOM order in ipa-prop.c Martin Jambor
2014-05-21 13:31 ` [PATCH 6/7] Real aggregate contents merge and application of deltas Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606132828.GA29831@virgil.suse \
--to=mjambor@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).