From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-369948-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4825 invoked by alias); 11 Jun 2014 08:17:47 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 4810 invoked by uid 89); 11 Jun 2014 08:17:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: nikam.ms.mff.cuni.cz
Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 11 Jun 2014 08:17:44 +0000
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)	id B4C09540753; Wed, 11 Jun 2014 10:17:41 +0200 (CEST)
Date: Wed, 11 Jun 2014 08:17:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Jan Hubicka <hubicka@ucw.cz>,	Richard Biener <richard.guenther@gmail.com>,	GCC Patches <gcc-patches@gcc.gnu.org>,	Richard Henderson <rth@redhat.com>, ramrad01@arm.com,	Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: ipa-visibility TLC 2/n
Message-ID: <20140611081741.GA8262@kam.mff.cuni.cz>
References: <20140528231723.GA31990@kam.mff.cuni.cz> <87bnuh9fdo.fsf@talisman.default> <20140529171214.GB32218@kam.mff.cuni.cz> <877g53ag1p.fsf@talisman.default> <CAGWvnyn1b_gDjoE9rfie0Q66Jmv7pYYMq+9NtNn5=cdJ8NPzrw@mail.gmail.com> <20140608165447.GC23686@kam.mff.cuni.cz> <20140608165838.GD23686@kam.mff.cuni.cz> <CAGWvny=RqnsPH7LGVmobJhOE8128UUz0Gtzp9_Nq5qmGsYXKxA@mail.gmail.com> <20140610180201.GE5439@kam.mff.cuni.cz> <CAGWvnyk76zqp8QY+yG0K_Ec4RVNtu+78Rfpt=wH+Q1iCi5TW5g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGWvnyk76zqp8QY+yG0K_Ec4RVNtu+78Rfpt=wH+Q1iCi5TW5g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SW-Source: 2014-06/txt/msg00868.txt.bz2

Deavid,
this is patch to disable the vtable rewriting on AIX.  I did not make much progress
on figuring out why it fails today - just observed that if I produce .o file for the
test and link it against libstdc++ built by older GCC it works. Also objects compiled
w/o optimization works, so I am bit puzzled here.

Honza

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 211436)
+++ ChangeLog	(working copy)
@@ -1,3 +1,9 @@
+2014-06-11  Jan Hubicka  <hubicka@ucw.cz>
+
+	* ipa-visibility.c (function_and_variable_visibility): Disable
+	virtual table rewriting temporarily on targets not supporting
+	ONE_ONLY.
+
 2014-06-11  Richard Biener  <rguenther@suse.de>
 
 	PR middle-end/61437
Index: ipa-visibility.c
===================================================================
--- ipa-visibility.c	(revision 211436)
+++ ipa-visibility.c	(working copy)
@@ -666,9 +666,12 @@ function_and_variable_visibility (bool w
 	}
       update_visibility_by_resolution_info (vnode);
 
-      /* Update virutal tables to point to local aliases where possible.  */
+      /* Update virtual tables to point to local aliases where possible.  */
       if (DECL_VIRTUAL_P (vnode->decl)
-	  && !DECL_EXTERNAL (vnode->decl))
+	  && !DECL_EXTERNAL (vnode->decl)
+	  /* FIXME: currently this optimization breaks on AIX.  Disable it for targets
+	     without comdat support for now.  */
+	  && SUPPORTS_ONE_ONLY)
 	{
 	  int i;
 	  struct ipa_ref *ref;