From: Jan Hubicka <hubicka@ucw.cz>
To: Rich Felker <dalias@libc.org>
Cc: Alexander Monakov <amonakov@ispras.ru>, Jeff Law <law@redhat.com>,
Richard Biener <richard.guenther@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] proposed fix for bug # 61144
Date: Mon, 16 Jun 2014 09:06:00 -0000 [thread overview]
Message-ID: <20140616090604.GB14894@kam.mff.cuni.cz> (raw)
In-Reply-To: <20140609184601.GI179@brightrain.aerifal.cx>
>
> Are the attached files acceptable?
The testcase looks OK to me, but it already should be fixed on mainline
by patch https://gcc.gnu.org/ml/gcc-patches/2014-05/msg01315.html that
prevents dummy to be marked as constant.
You can however modify the testcase to have
__attribute__ ((weak)) const int foo=0;
This needs your decl_replaceable change to not be optimized to if (0),
because of the explicit const modifier.
I did not change ctor_for_folding to reject variables above as I was not quite
sure we want to support this kind of interposition and I am still not quite certain.
C++ is quite clear about the transformation replacing initialized const by its value.
Honza
>
> Rich
> /* { dg-do run } */
> /* { dg-require-weak "" } */
> /* { dg-require-alias "" } */
> /* { dg-additional-sources "wkali-3a.c" } */
>
> #include <stdlib.h>
>
> static int dummy = 0;
> extern int foo __attribute__((__weak__, __alias__("dummy")));
>
> int main(void) {
>
> if (foo)
> exit(0);
> else
> abort();
> }
> /* { dg-do run } */
>
> int foo = 1;
next prev parent reply other threads:[~2014-06-16 9:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 1:59 Rich Felker
2014-05-21 9:17 ` Richard Biener
2014-05-22 3:59 ` Rich Felker
2014-05-23 18:26 ` Jeff Law
2014-06-06 17:14 ` Rich Felker
2014-06-09 11:41 ` Alexander Monakov
2014-06-09 18:46 ` Rich Felker
2014-06-16 9:06 ` Jan Hubicka [this message]
2014-06-16 13:38 ` Rich Felker
2014-06-16 16:05 ` Jan Hubicka
2014-06-16 16:35 ` Rich Felker
2014-06-14 21:24 ` Rich Felker
2014-06-16 8:56 ` Jan Hubicka
2014-07-22 17:18 ` Alexander Monakov
2014-07-22 17:23 ` Alexander Monakov
2014-07-22 17:30 ` Rich Felker
2014-07-23 9:06 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616090604.GB14894@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=amonakov@ispras.ru \
--cc=dalias@libc.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).