From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8774 invoked by alias); 20 Jun 2014 11:44:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8532 invoked by uid 89); 20 Jun 2014 11:44:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 20 Jun 2014 11:44:22 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6238FAC5D; Fri, 20 Jun 2014 11:44:19 +0000 (UTC) Date: Fri, 20 Jun 2014 11:44:00 -0000 From: Martin Jambor To: Bernd Edlinger Cc: Richard Biener , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Change default for --param allow-...-data-races to off Message-ID: <20140620114418.GB24436@virgil.suse> Mail-Followup-To: Bernd Edlinger , Richard Biener , "gcc-patches@gcc.gnu.org" References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg01604.txt.bz2 Hi, On Thu, Jun 19, 2014 at 06:18:47PM +0200, Bernd Edlinger wrote: > Hi, > > from a recent discussion on gcc@gcc.gnu.org I have learned that the default of > --param allow-store-data-races is still 1, and it is causing problems. > Therefore I would like to suggest to change the default of this option to 0. I was about to propose a similar patch but I intended to leave the parameter set to one when -Ofast is specified so that benchmarks are not hurt by this and as a nice pointer for people exploring our options to really squeeze out 100% performance (which would of course mean documenting it too). Thanks, Martin > > Boot-strapped and regression tested on x86_64-linux-gnu. > Ok for trunk? > > > Thanks > Bernd. > > gcc/ChangeLog: > 2014-06-19 Bernd Edlinger > > Set default for --param allow-...-data-races to off. > * params.def (PARAM_ALLOW_LOAD_DATA_RACES, > PARAM_ALLOW_STORE_DATA_RACES, PARAM_ALLOW_PACKED_LOAD_DATA_RACES, > PARAM_ALLOW_PACKED_STORE_DATA_RACES): Set default to off. > > testsuite/ChangeLog: > 2014-06-19 Bernd Edlinger > > Adjust to new default for --param allow-...-data-races. > * c-c++-common/cxxbitfields-3.c: Adjust. > * c-c++-common/cxxbitfields-6.c: Adjust. > * c-c++-common/simulate-thread/bitfields-1.c: Adjust. > * c-c++-common/simulate-thread/bitfields-2.c: Adjust. > * c-c++-common/simulate-thread/bitfields-3.c: Adjust. > * c-c++-common/simulate-thread/bitfields-4.c: Adjust. > * g++.dg/simulate-thread/bitfields.C: Adjust. > * g++.dg/simulate-thread/bitfields-2.C: Adjust. > * gcc.dg/lto/pr52097_0.c: Adjust. > * gcc.dg/simulate-thread/speculative-store.c: Adjust. > * gcc.dg/simulate-thread/speculative-store-2.c: Adjust. > * gcc.dg/simulate-thread/speculative-store-3.c: Adjust. > * gcc.dg/simulate-thread/speculative-store-4.c: Adjust. > * gcc.dg/simulate-thread/strict-align-global.c: Adjust. > * gcc.dg/simulate-thread/subfields.c: Adjust. > * gcc.dg/tree-ssa/20050314-1.c: Adjust. >