From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21429 invoked by alias); 3 Jul 2014 10:05:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21396 invoked by uid 89); 3 Jul 2014 10:05:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 03 Jul 2014 10:05:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s63A5M6Q030289 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2014 06:05:22 -0400 Received: from tucnak.zalov.cz (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s63A5KIH028266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 3 Jul 2014 06:05:21 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s63A5IQL029353; Thu, 3 Jul 2014 12:05:18 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s63A5Gex029352; Thu, 3 Jul 2014 12:05:16 +0200 Date: Thu, 03 Jul 2014 10:05:00 -0000 From: Jakub Jelinek To: Mark Wielaard Cc: gcc-patches@gcc.gnu.org, Jason Merrill , Cary Coutant , Alexandre Oliva Subject: Re: [PATCH] Add guality [p]type test. Message-ID: <20140703100516.GC31640@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1403265071.6147.5.camel@bordewijk.wildebeest.org> <1404381209-11280-1-git-send-email-mjw@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404381209-11280-1-git-send-email-mjw@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00190.txt.bz2 On Thu, Jul 03, 2014 at 11:53:29AM +0200, Mark Wielaard wrote: > I pulled out the guality.exp [p]type test extension from the actual > dwarf2out.c changes (which I will repost soon with some tweaks). I think > the test extension itself is useful on its own (and will use it to > add tests for my new patches). > > All new tests PASS, except when using -flto, so you'll need the > "Don't run guality.exp tests with LTO_TORTURE_OPTIONS" > if you don't want to add new FAILs. But I hope this patch can go in > even without that because I do think it is useful on its own. Is what gdb prints for ptype stable across different gdb versions (except for whitespace that you canonicalize)? If yes, this looks good to me. Jakub