From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9633 invoked by alias); 11 Jul 2014 18:46:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9601 invoked by uid 89); 11 Jul 2014 18:46:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: atrey.karlin.mff.cuni.cz Received: from atrey.karlin.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Jul 2014 18:46:15 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 5A46581D33; Fri, 11 Jul 2014 20:46:13 +0200 (CEST) Date: Fri, 11 Jul 2014 18:46:00 -0000 From: Jan Hubicka To: Rong Xu Cc: Xinliang David Li , Jakub Jelinek , Richard Biener , Jan Hubicka , GCC Patches , Xinliang David Li , Teresa Johnson , Dehao Chen Subject: Re: [PATCH] offline gcda profile processing tool Message-ID: <20140711184613.GC8908@atrey.karlin.mff.cuni.cz> References: <20140417033448.GC3157@kam.mff.cuni.cz> <20140711154426.GX31640@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00855.txt.bz2 > Richard, > > I looked at my patch again. I already add -Wno-error to libgcov-util.o > compilation: > In line 200 of gcc/Makefile.in > libgcov-util.o-warn = -Wno-error > > In my test, I used gcc-4.6 as the host compiler. I got warning like this: > > In file included from ../../gcc/gcc/../libgcc/libgcov-util.c:30:0: > ../../gcc/gcc/../libgcc/libgcov.h:184:30: warning: ISO C++ forbids > zero-size array ???ctrs??? [-pedantic] > > Can you check your buildlog to see if -Wno-error is added to the command line? I would preffer the libgcov.h (that is interface header to libgcov users) to be valid C++, so we still ought to fix it. Honza > > Thanks, > > -Rong > > On Fri, Jul 11, 2014 at 9:47 AM, Rong Xu wrote: > > I did see the warning in the bootstrap, but it did not exit the build. > > I thought it was ok. > > > > I'll have a patch for this and send for review. > > > > -Rong > > > > On Fri, Jul 11, 2014 at 9:13 AM, Xinliang David Li wrote: > >> right. > >> > >> Rong, the fix would be just change ctr array size to 1. For each > >> function, there should be at least one kind of counters -- see the > >> assertion in build_fn_info_type. There are some code that do > >> 'sizeof(gcov_fn_info)' when computing heap size -- they can be > >> adjusted or leave it as it is (if not doing memcpy for the whole > >> array). > >> > >> David > >> > >> On Fri, Jul 11, 2014 at 8:44 AM, Jakub Jelinek wrote: > >>> On Fri, Jul 11, 2014 at 08:42:27AM -0700, Xinliang David Li wrote: > >>>> I wonder why. The struct definition for gcov_fn_info has not changed > >>>> in this patch. > >>> > >>> Perhaps it has been used only in C until now? > >>> > >>> Jakub