public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Jason Merrill <jason@redhat.com>
Cc: Jan Hubicka <hubicka@ucw.cz>,
	gcc-patches@gcc.gnu.org,	rguenther@suse.de,
	mikestump@comcast.net, stanshebs@earthlink.net
Subject: Re: Move DECL_ARGUMENTS into tree_function_decl
Date: Mon, 14 Jul 2014 15:24:00 -0000	[thread overview]
Message-ID: <20140714151445.GC3663@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <53C3E1B5.1060708@redhat.com>

> On 06/25/2014 02:51 AM, Jan Hubicka wrote:
> >@@ -4388,7 +4388,8 @@ build_clone (tree fn, tree name)
> >    clone = copy_decl (fn);
> >    /* Reset the function name.  */
> >    DECL_NAME (clone) = name;
> >-  SET_DECL_ASSEMBLER_NAME (clone, NULL_TREE);
> >+  if (TREE_CODE (clone) != TEMPLATE_DECL)
> >+    SET_DECL_ASSEMBLER_NAME (clone, NULL_TREE);
> 
> Instead of this, move the SET_DECL_ASSEMBLER_NAME down below the
> template block.
> 
> OK with that change.
Thanks a lot!
I wonder how necessary are those DECL_RTL/DECL_ASSEMBLER_NAME hacks
these days. THeoretically those should be computed only late once clonning is done.

Honza
> 
> Jason

      reply	other threads:[~2014-07-14 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25  6:51 Jan Hubicka
2014-07-14  8:42 ` Jan Hubicka
2014-07-14 14:01 ` Jason Merrill
2014-07-14 15:24   ` Jan Hubicka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714151445.GC3663@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=mikestump@comcast.net \
    --cc=rguenther@suse.de \
    --cc=stanshebs@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).