From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8164 invoked by alias); 23 Jul 2014 11:42:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8154 invoked by uid 89); 23 Jul 2014 11:42:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 23 Jul 2014 11:42:40 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 Jul 2014 12:42:37 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 Jul 2014 12:42:35 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 04FD32190056 for ; Wed, 23 Jul 2014 12:42:20 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6NBgYQH36044938 for ; Wed, 23 Jul 2014 11:42:34 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6NBgYOT019123 for ; Wed, 23 Jul 2014 05:42:34 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id s6NBgXCD019089 for ; Wed, 23 Jul 2014 05:42:33 -0600 Message-Id: <201407231142.s6NBgXCD019089@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 23 Jul 2014 13:42:33 +0200 Subject: [PING, PATCH, testsuite] Reliably prune GCC notes in C++ compat suite To: gcc-patches@gcc.gnu.org Date: Wed, 23 Jul 2014 11:52:00 -0000 From: "Ulrich Weigand" In-Reply-To: <201407170050.s6H0ouIa030202@d06av02.portsmouth.uk.ibm.com> from "Ulrich Weigand" at Jul 17, 2014 02:50:56 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14072311-2966-0000-0000-0000009AFA30 X-SW-Source: 2014-07/txt/msg01514.txt.bz2 Ping? > Hello, > > in testing the rs6000 ABI patches I noted a weird effect: usually, the > -Wpsabi warning notes are ignored in the compat test suites, so we get > a clean test run anyway. > > However, when running the C++ version of the struct-layout-1.exp case > *alone* (using RUNTESTFLAGS=struct-layout-1.exp), suddenly tests are > failing because of those extra notes. This does *not* happen with > the C version of that suite ... > > It turns out that that pruning those notes is supposed to happen > from within gcc-defs.exp:${tool}_check_compile: > if { [info proc ${tool}-dg-prune] != "" } { > global target_triplet > set gcc_output [${tool}-dg-prune $target_triplet $gcc_output] > } > > However, the g++-dg-prune routine is defined in g++-dg.exp, which > is never included from g++.dg/compat/struct-layout-1.exp (directly > or indirectly). Now, when running the full suite, that file would > have been loaded by some earlier g++.dg .exp file, so everything > works out. But when running struct-layout-1.exp stand-alone, the > g++-dg-prune routine is never defined and thus silently no pruning > takes place. > > To fix this, the following patch simply loads g++-dg.exp directly > from g++.dg/compat/struct-layout-1.exp. > > Tested on powerpc64-linux and powerpc64le-linux. > > OK for mainline (and 4.8/4.9 once the rs6000 ABI patches are > backported there)? > > Bye, > Ulrich > > > gcc/testsuite/ChangeLog: > > * g++.dg/compat/struct-layout-1.exp: Load g++-dg.exp > > > Index: gcc-4_9-branch/gcc/testsuite/g++.dg/compat/struct-layout-1.exp > =================================================================== > --- gcc-4_9-branch.orig/gcc/testsuite/g++.dg/compat/struct-layout-1.exp > +++ gcc-4_9-branch/gcc/testsuite/g++.dg/compat/struct-layout-1.exp > @@ -89,6 +89,9 @@ proc compat-use-tst-compiler { } { > # This must be done after the compat-use-*-compiler definitions. > load_lib compat.exp > > +# Provide the g++-dg-prune routine (gcc-dp.exp is loaded by compat.exp) > +load_lib g++-dg.exp > + > g++_init > > # Save variables for the C++ compiler under test, which each test will > > -- > Dr. Ulrich Weigand > GNU/Linux compilers and toolchain > Ulrich.Weigand@de.ibm.com > -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com