public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed] Fix pr61077.c test
@ 2014-07-26 16:55 Marek Polacek
  2014-07-26 17:59 ` Mike Stump
  2014-07-27  2:12 ` Jakub Jelinek
  0 siblings, 2 replies; 3+ messages in thread
From: Marek Polacek @ 2014-07-26 16:55 UTC (permalink / raw)
  To: GCC Patches

Marc reported that using .* regexp can cause spurious fails, so
fixed by using \[^\n\]* instead.

Tested on x86_64-linux, applying to trunk.

2014-07-26  Marek Polacek  <polacek@redhat.com>

	* gcc.dg/pr61077.c: Use \[^\n\]* instead of .* in the regexp.

diff --git gcc/testsuite/gcc.dg/pr61077.c gcc/testsuite/gcc.dg/pr61077.c
index c0513f7..e29f23c 100644
--- gcc/testsuite/gcc.dg/pr61077.c
+++ gcc/testsuite/gcc.dg/pr61077.c
@@ -5,8 +5,8 @@
 _Atomic int
 main (_Atomic int argc, _Atomic char **argv)
 /* { dg-warning "qualified return type" "return" { target *-*-* } 6 } */
-/* { dg-warning "qualified parameter type.*int" "parameter" { target *-*-* } 6 } */
-/* { dg-warning "qualified parameter type.*char" "parameter" { target *-*-* } 6 } */
+/* { dg-warning "qualified parameter type\[^\n\]*int" "parameter" { target *-*-* } 6 } */
+/* { dg-warning "qualified parameter type\[^\n\]*char" "parameter" { target *-*-* } 6 } */
 {
   return 0;
 }

	Marek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [committed] Fix pr61077.c test
  2014-07-26 16:55 [committed] Fix pr61077.c test Marek Polacek
@ 2014-07-26 17:59 ` Mike Stump
  2014-07-27  2:12 ` Jakub Jelinek
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Stump @ 2014-07-26 17:59 UTC (permalink / raw)
  To: Marek Polacek; +Cc: GCC Patches

On Jul 26, 2014, at 9:30 AM, Marek Polacek <polacek@redhat.com> wrote:
> Marc reported that using .* regexp can cause spurious fails, so
> fixed by using \[^\n\]* instead.

Yeah, that’s a perennial non-obviousness and a slightly bad interface.  Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [committed] Fix pr61077.c test
  2014-07-26 16:55 [committed] Fix pr61077.c test Marek Polacek
  2014-07-26 17:59 ` Mike Stump
@ 2014-07-27  2:12 ` Jakub Jelinek
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Jelinek @ 2014-07-27  2:12 UTC (permalink / raw)
  To: Marek Polacek; +Cc: GCC Patches

On Sat, Jul 26, 2014 at 06:30:30PM +0200, Marek Polacek wrote:
> Marc reported that using .* regexp can cause spurious fails, so
> fixed by using \[^\n\]* instead.
> 
> Tested on x86_64-linux, applying to trunk.
> 
> 2014-07-26  Marek Polacek  <polacek@redhat.com>
> 
> 	* gcc.dg/pr61077.c: Use \[^\n\]* instead of .* in the regexp.
> 
> diff --git gcc/testsuite/gcc.dg/pr61077.c gcc/testsuite/gcc.dg/pr61077.c
> index c0513f7..e29f23c 100644
> --- gcc/testsuite/gcc.dg/pr61077.c
> +++ gcc/testsuite/gcc.dg/pr61077.c
> @@ -5,8 +5,8 @@
>  _Atomic int
>  main (_Atomic int argc, _Atomic char **argv)
>  /* { dg-warning "qualified return type" "return" { target *-*-* } 6 } */
> -/* { dg-warning "qualified parameter type.*int" "parameter" { target *-*-* } 6 } */
> -/* { dg-warning "qualified parameter type.*char" "parameter" { target *-*-* } 6 } */
> +/* { dg-warning "qualified parameter type\[^\n\]*int" "parameter" { target *-*-* } 6 } */
> +/* { dg-warning "qualified parameter type\[^\n\]*char" "parameter" { target *-*-* } 6 } */

Usually we use \[^\n\r\] instead.

	Jakub

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-26 21:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-26 16:55 [committed] Fix pr61077.c test Marek Polacek
2014-07-26 17:59 ` Mike Stump
2014-07-27  2:12 ` Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).