public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: Paolo Carlini <paolo.carlini@oracle.com>,
	       Jonathan Wakely <jwakely.gcc@gmail.com>,
	       "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: testsuite allocators patch
Date: Tue, 29 Jul 2014 19:42:00 -0000	[thread overview]
Message-ID: <20140729192753.GZ2361@redhat.com> (raw)
In-Reply-To: <53D01C0B.2030203@gmail.com>

On 23/07/14 22:33 +0200, François Dumont wrote:
>On 27/06/2014 21:48, Paolo Carlini wrote:
>>Hi,
>>
>>On 06/27/2014 07:33 PM, Jonathan Wakely wrote:
>>>I didn't see an obvious fix (I'm not sure if the templated constructor
>>>can deduce its argument since the change) but have been out all day
>>>and not had a chance to look into it.
>>Ok, thanks. I'm reverting the last two libstdc++-v3 commits.
>>
>>Paolo.
>>
>
>Hi
>
>    Back from vacation, ready to have this patch committed eventually.
>
>    Here is the new version with the missing default and copy constructor.
>
>    I have a small question regarding some code next to the one I am 
>modifying in this patch. I can see lines like:
>
>      propagating_allocator() noexcept = default;
>
>    When using a default implementation shouldn't we let the compiler 
>decide if it should be noexcept or not depending on the member fields 
>or base class default constructors ?
>
>    Tested under Linux x86_64.
>
>    Ok to commit ?

OK, thanks.

      parent reply	other threads:[~2014-07-29 19:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 20:37 François Dumont
2014-06-25 19:48 ` François Dumont
2014-06-26 10:33   ` Jonathan Wakely
2014-06-26 20:45     ` François Dumont
2014-06-26 21:24       ` Paolo Carlini
2014-06-26 22:39         ` Jonathan Wakely
2014-06-27  7:30           ` Paolo Carlini
2014-06-27 17:33             ` Jonathan Wakely
2014-06-27 19:51               ` Paolo Carlini
2014-06-27 21:29                 ` François Dumont
2014-07-23 20:46                 ` François Dumont
2014-07-24  8:58                   ` Jonathan Wakely
2014-07-24 20:30                     ` François Dumont
2014-07-24 23:36                       ` Jonathan Wakely
2014-07-29 21:34                         ` Jonathan Wakely
2014-07-29 21:44                           ` Jonathan Wakely
2014-07-29 19:42                   ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729192753.GZ2361@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely.gcc@gmail.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=paolo.carlini@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).