From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: rohitarulraj@freescale.com
Cc: gcc-patches@gcc.gnu.org (gcc-patches@gcc.gnu.org),
edmar@freescale.com (Edmar Wienskoski),
dje.gcc@gmail.com (dje.gcc@gmail.com),
amodra@gmail.com (Alan Modra),
jakub@redhat.com (Jakub Jelinek)
Subject: Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno
Date: Fri, 01 Aug 2014 14:29:00 -0000 [thread overview]
Message-ID: <201408011428.s71ESvBE005167@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <e1ed4a3799764ae482037722effa1303@BN1PR0301MB0644.namprd03.prod.outlook.com> from "rohitarulraj@freescale.com" at Jul 31, 2014 06:11:22 PM
Rohit,
> #define DWARF_REG_TO_UNWIND_COLUMN(r) \
>- ((r) > 1200 ? ((r) - 1200 + (DWARF_FRAME_REGISTERS - 32)) : (r))
>+ ((r) >= 1200 ? ((r) - 1200 + (DWARF_FRAME_REGISTERS - 32)) : (r))
OK, makes sense.
> /* Use gcc hard register numbering for eh_frame. */
>-#define DWARF_FRAME_REGNUM(REGNO) (REGNO)
>+#define DWARF_FRAME_REGNUM(REGNO) \
>+ ((REGNO) >= FIRST_SPE_HIGH_REGNO ? ((REGNO) - FIRST_SPE_HIGH_REGNO + 1200) : (REGNO))
Any reason for not using SPE_HIGH_REGNO_P here, just in case we
do get other hard registers at some point?
Otherwise this now looks good to me. (Of course, I cannot
approve the patch myself.)
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2014-08-01 14:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 2:42 [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices at dwf_regno rohitarulraj
2014-07-22 7:28 ` rohitarulraj
2014-07-24 16:54 ` [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno Ulrich Weigand
2014-07-31 18:23 ` rohitarulraj
2014-08-01 14:29 ` Ulrich Weigand [this message]
2014-08-01 18:04 ` rohitarulraj
2014-08-01 18:10 ` Jakub Jelinek
2014-08-01 18:21 ` rohitarulraj
2014-08-02 1:46 ` David Edelsohn
2014-08-04 10:25 ` Ulrich Weigand
2014-08-04 16:56 ` Edmar
2014-08-05 8:11 ` Jakub Jelinek
2014-08-05 10:44 ` rohitarulraj
2014-08-05 14:47 ` Edmar
2014-09-28 22:23 ` Maciej W. Rozycki
2014-09-29 9:44 ` Ulrich Weigand
2014-09-29 10:24 ` rohitarulraj
2014-09-29 17:26 ` Maciej W. Rozycki
2014-10-06 15:48 ` rohitarulraj
2014-10-08 18:09 ` Ulrich Weigand
2014-10-08 18:27 ` David Edelsohn
2014-10-08 19:47 ` Maciej W. Rozycki
2014-10-09 12:20 ` rohitarulraj
2014-10-09 13:40 ` Ulrich Weigand
2014-10-09 15:49 ` Maciej W. Rozycki
2014-10-11 14:49 ` Maciej W. Rozycki
2014-10-13 13:22 ` Ulrich Weigand
2014-10-13 17:39 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201408011428.s71ESvBE005167@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=edmar@freescale.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rohitarulraj@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).