From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6037 invoked by alias); 8 Aug 2014 08:07:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6019 invoked by uid 89); 8 Aug 2014 08:07:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Aug 2014 08:07:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7887oSb024086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Aug 2014 04:07:51 -0400 Received: from tucnak.zalov.cz (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7887m1N011883 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 8 Aug 2014 04:07:50 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s7887k7B008693; Fri, 8 Aug 2014 10:07:46 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s7887iRb008692; Fri, 8 Aug 2014 10:07:44 +0200 Date: Fri, 08 Aug 2014 08:07:00 -0000 From: Jakub Jelinek To: Yury Gribov Cc: Richard Biener , GCC Patches , Konstantin Serebryany , Dmitry Vyukov , Viacheslav Garbuzov , Marek Polacek Subject: Re: [PATCH 1/2] Support fnspecs for internal functions Message-ID: <20140808080744.GN7393@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <53CE720A.4030002@samsung.com> <20140723200935.GB2397@laptop.redhat.com> <53D0A5DA.4020301@samsung.com> <20140724074851.GD2397@laptop.redhat.com> <53D65AB0.4090807@samsung.com> <20140801071757.GC7393@tucnak.redhat.com> <53E46A0D.6020602@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53E46A0D.6020602@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00869.txt.bz2 On Fri, Aug 08, 2014 at 10:11:25AM +0400, Yury Gribov wrote: > commit b90c4abf0b804c60b548f94fe59118d029363140 > Author: Yury Gribov > Date: Wed Aug 6 11:05:39 2014 +0400 > > Added fnspec to internal functions. > > 2014-08-08 Yury Gribov > > * gimple.c (gimple_call_fnspec): Support internal functions. > (gimple_call_return_flags): Use const. > * Makefile.in: Add internal-fn.h to list of GC files. > * internal-fn.def: Add fnspec information. > * internal-fn.h (internal_fn_fnspec): New function. > (init_internal_fns): Declare new function. > * internal-fn.c (internal_fn_fnspec_array): New global variable. > (init_internal_fns): New function. > * tree-core.h: Update macro call. > * tree.c (build_common_builtin_nodes): Initialize internal fns. Ok, thanks, with a minor nit: > --- a/gcc/tree.c > +++ b/gcc/tree.c > @@ -9870,8 +9870,9 @@ local_define_builtin (const char *name, tree type, enum built_in_function code, > } > > /* Call this function after instantiating all builtins that the language > - front end cares about. This will build the rest of the builtins that > - are relied upon by the tree optimizers and the middle-end. */ > + front end cares about. This will build the rest of the builtins > + and internal function that are relied upon by the tree optimizers and s/function/functions/ Jakub