From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10105 invoked by alias); 12 Aug 2014 21:16:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10093 invoked by uid 89); 12 Aug 2014 21:16:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.mozilla.org Received: from mx2.corp.phx1.mozilla.com (HELO smtp.mozilla.org) (63.245.216.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Aug 2014 21:16:09 +0000 Received: from tsaunders-iceball.corp.tor1.mozilla.com (unknown [64.213.68.131]) (Authenticated sender: tsaunders@mozilla.com) by mx2.mail.corp.phx1.mozilla.com (Postfix) with ESMTPSA id 4E06AF258C; Tue, 12 Aug 2014 14:16:07 -0700 (PDT) Date: Tue, 12 Aug 2014 21:16:00 -0000 From: Trevor Saunders To: Jeff Law Cc: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 001/236] Convert lab_rtx_for_bb from pointer_map_t to pointer_map Message-ID: <20140812211548.GA28581@tsaunders-iceball.corp.tor1.mozilla.com> References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-2-git-send-email-dmalcolm@redhat.com> <53EA7E1F.1030906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53EA7E1F.1030906@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01211.txt.bz2 On Tue, Aug 12, 2014 at 02:50:39PM -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > >This gives a slight improvement in typesafety in cfgexpand.c > > > >gcc/ > > * cfgexpand.c (lab_rtx_for_bb): Convert from pointer_map_t to > > pointer_map. > > (label_rtx_for_bb): Update for conversion of lab_rtx_for_bb to > > a pointer_map, eliminating casts from void* to rtx. > > (expand_gimple_basic_block): Likewise. > > (pass_expand::execute): Likewise, using new/delete of > > pointer_map rathern than pointer_map_create/destroy. NULLify > > the lab_rtx_for_bb ptr after deletion for good measure. > OK. I think this is still appropriate. It might even still apply > cleanly. actually I suspect this patch is totally obsolete after my patches last week to remove pointer_map. This is now a hash_map *. sorry about the duplicated effort :/ Trev > > Seems like this could have gone forward independently of everything else. > > > jeff > >