* Re: [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N)
@ 2014-08-25 15:45 David Edelsohn
2014-08-25 15:55 ` Jan-Benedict Glaw
0 siblings, 1 reply; 5+ messages in thread
From: David Edelsohn @ 2014-08-25 15:45 UTC (permalink / raw)
To: Jan-Benedict Glaw, Martin Liska; +Cc: GCC Patches
2014-08.25 Jan-Benedict Glaw <jbglaw@lug-owl.de>
* config/rs6000/rs6000.c (rs6000_return_in_msb): Fix fallout from
cgraph_state conversion.
The patch seems reasonable to me based on the other changes.
Thanks, David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N)
2014-08-25 15:45 [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N) David Edelsohn
@ 2014-08-25 15:55 ` Jan-Benedict Glaw
0 siblings, 0 replies; 5+ messages in thread
From: Jan-Benedict Glaw @ 2014-08-25 15:55 UTC (permalink / raw)
To: David Edelsohn; +Cc: Martin Liska, GCC Patches
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On Mon, 2014-08-25 11:44:58 -0400, David Edelsohn <dje.gcc@gmail.com> wrote:
> 2014-08.25 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/rs6000/rs6000.c (rs6000_return_in_msb): Fix fallout from
> cgraph_state conversion.
>
>
> The patch seems reasonable to me based on the other changes.
Committed as r214429.
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Zensur im Internet? Nein danke!
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N)
2014-08-25 16:09 ` Martin Liška
@ 2014-08-25 16:32 ` Jan-Benedict Glaw
0 siblings, 0 replies; 5+ messages in thread
From: Jan-Benedict Glaw @ 2014-08-25 16:32 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]
On Mon, 2014-08-25 18:09:09 +0200, Martin Liška <mliska@suse.cz> wrote:
> On 08/25/2014 05:29 PM, Jan-Benedict Glaw wrote:
> > Your recent change left one cgraph_state in place in the rs6000
> > backend, resulting in (see
> > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346638
> > and
> > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346630):
> >
> >g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o rs6000.o -MT rs6000.o -MMD -MP -MF ./.deps/rs6000.TPo /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c
> >/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘bool call_ABI_of_interest(tree_node*)’:
> >/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:9057: error: ‘cgraph_state’ was not declared in this scope
> >/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:9057: error: ‘CGRAPH_STATE_EXPANSION’ was not declared in this scope
[...]
> > make[1]: *** [rs6000.o] Error 1
>
> Hello Jan-Benedict,
> thank you for the fallout fix. Even though I tested all
> back-ends, I am unable to build a cross-compiler:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61974.
Builds for me eg. here:
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346652
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser.
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N)
2014-08-25 15:30 Jan-Benedict Glaw
@ 2014-08-25 16:09 ` Martin Liška
2014-08-25 16:32 ` Jan-Benedict Glaw
0 siblings, 1 reply; 5+ messages in thread
From: Martin Liška @ 2014-08-25 16:09 UTC (permalink / raw)
To: Jan-Benedict Glaw; +Cc: gcc-patches
On 08/25/2014 05:29 PM, Jan-Benedict Glaw wrote:
> Hi!
>
> Your recent change left one cgraph_state in place in the rs6000
> backend, resulting in (see
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346638
> and
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346630):
>
> g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o rs6000.o -MT rs6000.o -MMD -MP -MF ./.deps/rs6000.TPo /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘bool call_ABI_of_interest(tree_node*)’:
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:9057: error: ‘cgraph_state’ was not declared in this scope
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:9057: error: ‘CGRAPH_STATE_EXPANSION’ was not declared in this scope
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘tree_node* rs6000_handle_longcall_attribute(tree_node**, tree_node*, tree_node*, int, bool*)’:
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28517: warning: unknown conversion type character ‘E’ in format
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28517: warning: too many arguments for format
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘tree_node* rs6000_handle_struct_attribute(tree_node**, tree_node*, tree_node*, int, bool*)’:
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28590: warning: unknown conversion type character ‘E’ in format
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28590: warning: too many arguments for format
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28600: warning: unknown conversion type character ‘E’ in format
> /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28600: warning: too many arguments for format
> make[1]: *** [rs6000.o] Error 1
Hello Jan-Benedict,
thank you for the fallout fix. Even though I tested all back-ends, I
am unable to build a cross-compiler:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61974.
Thanks,
Martin
>
>
>
> This should fix it, ok to apply?
>
>
> 2014-08.25 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/rs6000/rs6000.c (rs6000_return_in_msb): Fix fallout from
> cgraph_state conversion.
>
> diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
> index 00fa070..225f21e 100644
> --- a/gcc/config/rs6000/rs6000.c
> +++ b/gcc/config/rs6000/rs6000.c
> @@ -9054,7 +9054,7 @@ rs6000_return_in_msb (const_tree valtype)
> static bool
> call_ABI_of_interest (tree fndecl)
> {
> - if (cgraph_state == CGRAPH_STATE_EXPANSION)
> + if (symtab->state == EXPANSION)
> {
> struct cgraph_node *c_node;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N)
@ 2014-08-25 15:30 Jan-Benedict Glaw
2014-08-25 16:09 ` Martin Liška
0 siblings, 1 reply; 5+ messages in thread
From: Jan-Benedict Glaw @ 2014-08-25 15:30 UTC (permalink / raw)
To: Martin Liska; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 3187 bytes --]
Hi!
Your recent change left one cgraph_state in place in the rs6000
backend, resulting in (see
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346638
and
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=346630):
g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o rs6000.o -MT rs6000.o -MMD -MP -MF ./.deps/rs6000.TPo /home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘bool call_ABI_of_interest(tree_node*)’:
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:9057: error: ‘cgraph_state’ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:9057: error: ‘CGRAPH_STATE_EXPANSION’ was not declared in this scope
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘tree_node* rs6000_handle_longcall_attribute(tree_node**, tree_node*, tree_node*, int, bool*)’:
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28517: warning: unknown conversion type character ‘E’ in format
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28517: warning: too many arguments for format
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c: In function ‘tree_node* rs6000_handle_struct_attribute(tree_node**, tree_node*, tree_node*, int, bool*)’:
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28590: warning: unknown conversion type character ‘E’ in format
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28590: warning: too many arguments for format
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28600: warning: unknown conversion type character ‘E’ in format
/home/jbglaw/repos/gcc/gcc/config/rs6000/rs6000.c:28600: warning: too many arguments for format
make[1]: *** [rs6000.o] Error 1
This should fix it, ok to apply?
2014-08.25 Jan-Benedict Glaw <jbglaw@lug-owl.de>
* config/rs6000/rs6000.c (rs6000_return_in_msb): Fix fallout from
cgraph_state conversion.
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index 00fa070..225f21e 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -9054,7 +9054,7 @@ rs6000_return_in_msb (const_tree valtype)
static bool
call_ABI_of_interest (tree fndecl)
{
- if (cgraph_state == CGRAPH_STATE_EXPANSION)
+ if (symtab->state == EXPANSION)
{
struct cgraph_node *c_node;
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: 17:44 <@uschebit> Evangelist ist doch ein Vertriebler
the second : für unverkäufliche Produkte, oder? (#korsett, 20120821)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-25 16:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-25 15:45 [BUILDROBOT][PATCH] ppc{,64}-linux broken (IPA C++ refactoring 4/N) David Edelsohn
2014-08-25 15:55 ` Jan-Benedict Glaw
-- strict thread matches above, loose matches on Subject: below --
2014-08-25 15:30 Jan-Benedict Glaw
2014-08-25 16:09 ` Martin Liška
2014-08-25 16:32 ` Jan-Benedict Glaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).