From: Jakub Jelinek <jakub@redhat.com>
To: Maxim Ostapenko <m.ostapenko@partner.samsung.com>
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
Yury Gribov <y.gribov@samsung.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Slava Garbuzov <v.garbuzov@samsung.com>
Subject: Re: [PATCH] Fix libbacktrace and libiberty tests fail on sanitized GCC due to wrong link options.
Date: Mon, 01 Sep 2014 07:29:00 -0000 [thread overview]
Message-ID: <20140901072926.GE17454@tucnak.redhat.com> (raw)
In-Reply-To: <54041DEB.2080906@partner.samsung.com>
On Mon, Sep 01, 2014 at 11:19:07AM +0400, Maxim Ostapenko wrote:
> libiberty/ChangeLog:
>
> 2014-09-01 Max Ostapenko <m.ostapenko@partner.samsung.com>
>
> * testsuite/Makefile.in(LIBCFLAGS): Add LDFLAGS.
Space before (.
> # Flags to pass down to makes which are built with the target environment.
> # The double $ decreases the length of the command line; those variables
> # are set in BASE_FLAGS_TO_PASS, and the sub-make will expand them. The
> @@ -3518,9 +3526,9 @@ check-bfd:
> @: $(MAKE); $(unstage)
> @r=`${PWD_COMMAND}`; export r; \
> s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
> - $(HOST_EXPORTS) \
> + $(HOST_EXPORTS) $(EXTRA_HOST_EXPORTS) \
> (cd $(HOST_SUBDIR)/bfd && \
> - $(MAKE) $(FLAGS_TO_PASS) check)
> + $(MAKE) $(FLAGS_TO_PASS) $(EXTRA_BOOTSTRAP_FLAGS) check)
I'd put the double space right before check instead of in between
different flags, or use a single space everywhere.
> @@ -4392,9 +4400,9 @@ check-opcodes:
> @: $(MAKE); $(unstage)
> @r=`${PWD_COMMAND}`; export r; \
> s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
> - $(HOST_EXPORTS) \
> + $(HOST_EXPORTS) $(EXTRA_HOST_EXPORTS) \
> (cd $(HOST_SUBDIR)/opcodes && \
> - $(MAKE) $(FLAGS_TO_PASS) check)
> + $(MAKE) $(FLAGS_TO_PASS) $(EXTRA_BOOTSTRAP_FLAGS) check)
Ditto etc.
> @@ -6138,7 +6146,7 @@ check-cgen:
> @: $(MAKE); $(unstage)
> @r=`${PWD_COMMAND}`; export r; \
> s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
> - $(HOST_EXPORTS) \
> + $(HOST_EXPORTS) \
Why?
Jakub
next prev parent reply other threads:[~2014-09-01 7:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 7:05 Maxim Ostapenko
2014-08-25 14:24 ` Yury Gribov
2014-08-25 15:21 ` Bernhard Reutner-Fischer
2014-09-01 7:19 ` Maxim Ostapenko
2014-09-01 7:29 ` Jakub Jelinek [this message]
2014-09-01 8:33 ` Maxim Ostapenko
2014-09-08 15:57 ` [Ping][PATCH] " Maxim Ostapenko
2014-11-05 16:48 [PATCH] " Maxim Ostapenko
2015-01-28 10:24 Maxim Ostapenko
2015-01-28 21:43 ` DJ Delorie
2015-01-29 9:49 ` Maxim Ostapenko
2015-01-30 1:32 ` DJ Delorie
2015-04-14 14:31 Maxim Ostapenko
2015-04-14 16:02 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901072926.GE17454@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=m.ostapenko@partner.samsung.com \
--cc=rep.dot.nop@gmail.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).