From: James Greenhalgh <james.greenhalgh@arm.com>
To: Marcus Shawcroft <marcus.shawcroft@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [AArch64] Cheap fix for argument types of vmull_high_lane_{us}{16,32}
Date: Thu, 11 Sep 2014 15:13:00 -0000 [thread overview]
Message-ID: <20140911151342.GA26836@arm.com> (raw)
In-Reply-To: <CAFqB+PwnhY8+WKHL+eC14YqfjrR9m+q1Fv4NY4dTfj6ALTth1g@mail.gmail.com>
On Thu, Sep 11, 2014 at 03:26:49PM +0100, Marcus Shawcroft wrote:
> On 11 September 2014 13:15, James Greenhalgh <james.greenhalgh@arm.com> wrote:
> >
> > Hi,
> >
> > I'd been putting this patch off in the hope that I might find
> > time to move these intrinsics to a C/builtin implementation, but it
> > is probably better to get them right for now and come back to improving
> > them later.
> >
> > All four of these suffer the same problem, their "lane" argument should
> > be a 64-bit rather than 128-bit vector.
> >
> > Fix it the obvious way.
> >
> > Tested cross on aarch64-none-eabi.
> >
> > OK?
>
> OK /Marcus
>
Thanks Marcus,
After your offline pre-approval I've also backported this fix to the 4.9
branch as revision 215178.
Cheers,
James
prev parent reply other threads:[~2014-09-11 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 12:15 James Greenhalgh
2014-09-11 14:26 ` Marcus Shawcroft
2014-09-11 15:13 ` James Greenhalgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911151342.GA26836@arm.com \
--to=james.greenhalgh@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcus.shawcroft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).