public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* (Corrected patch) Simple patch for gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c
@ 2014-09-05 13:46 David Sherwood
  2014-09-05 14:58 ` Marcus Shawcroft
  0 siblings, 1 reply; 3+ messages in thread
From: David Sherwood @ 2014-09-05 13:46 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Apologies, resent with correct patch not containing ChangeLog changes.
----

Hi,

I have a simple patch for the vdup_lane_2.c test that fixes up the
force_simd macro so that it does
something sensible for execute type test cases. Is this ok to install?

Tested on aarch64 little and big endian.

Regards,
David Sherwood.

ChangeLog:
2014-09-02  David Sherwood  <david.sherwood@arm.com>

        * gcc.target/aarch64/vdup_lane_2.c (force_simd): Emit simd mov.



[-- Attachment #2: test_fix.patch --]
[-- Type: application/octet-stream, Size: 659 bytes --]

diff --git a/gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c b/gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c
index c4183ce..43ff5cc 100644
--- a/gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c
@@ -4,10 +4,10 @@
 
 #include <arm_neon.h>
 
-#define force_simd(V1)   asm volatile (""	\
-          : "=w"(V1)				\
-          : "w"(V1)				\
-          : /* No clobbers */)
+#define force_simd(V1) asm volatile ("mov %d0, %1.d[0]" \
+         : "=w"(V1)                                     \
+         : "w"(V1)                                      \
+         : /* No clobbers */)
 
 extern void abort (void);
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (Corrected patch) Simple patch for gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c
  2014-09-05 13:46 (Corrected patch) Simple patch for gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c David Sherwood
@ 2014-09-05 14:58 ` Marcus Shawcroft
  2014-09-15 10:03   ` James Greenhalgh
  0 siblings, 1 reply; 3+ messages in thread
From: Marcus Shawcroft @ 2014-09-05 14:58 UTC (permalink / raw)
  To: David Sherwood; +Cc: gcc-patches

On 5 September 2014 14:46, David Sherwood <david.sherwood@arm.com> wrote:
> Apologies, resent with correct patch not containing ChangeLog changes.
> ----
>
> Hi,
>
> I have a simple patch for the vdup_lane_2.c test that fixes up the
> force_simd macro so that it does
> something sensible for execute type test cases. Is this ok to install?
>
> Tested on aarch64 little and big endian.
>
> Regards,
> David Sherwood.
>
> ChangeLog:
> 2014-09-02  David Sherwood  <david.sherwood@arm.com>
>
>         * gcc.target/aarch64/vdup_lane_2.c (force_simd): Emit simd mov.

OK, thanks
/Marcus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (Corrected patch) Simple patch for gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c
  2014-09-05 14:58 ` Marcus Shawcroft
@ 2014-09-15 10:03   ` James Greenhalgh
  0 siblings, 0 replies; 3+ messages in thread
From: James Greenhalgh @ 2014-09-15 10:03 UTC (permalink / raw)
  To: Marcus Shawcroft; +Cc: David Sherwood, gcc-patches

On Fri, Sep 05, 2014 at 03:58:30PM +0100, Marcus Shawcroft wrote:
> On 5 September 2014 14:46, David Sherwood <david.sherwood@arm.com> wrote:
> > Apologies, resent with correct patch not containing ChangeLog changes.
> > ----
> >
> > Hi,
> >
> > I have a simple patch for the vdup_lane_2.c test that fixes up the
> > force_simd macro so that it does
> > something sensible for execute type test cases. Is this ok to install?
> >
> > Tested on aarch64 little and big endian.
> >
> > Regards,
> > David Sherwood.
> >
> > ChangeLog:
> > 2014-09-02  David Sherwood  <david.sherwood@arm.com>
> >
> >         * gcc.target/aarch64/vdup_lane_2.c (force_simd): Emit simd mov.
> 
> OK, thanks
> /Marcus

One of my builds over the weekend tripped up because of this bug and
I don't see David in MAINTAINERS, so I don't think he has commit rights.

Consequently, I've committed this patch on David's behalf as revision 215260

Thanks,
James

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-15 10:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-05 13:46 (Corrected patch) Simple patch for gcc/testsuite/gcc.target/aarch64/vdup_lane_2.c David Sherwood
2014-09-05 14:58 ` Marcus Shawcroft
2014-09-15 10:03   ` James Greenhalgh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).