From: Trevor Saunders <tsaunders@mozilla.com>
To: Yury Gribov <y.gribov@samsung.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Laurynas Biveinis <laurynas.biveinis@gmail.com>,
Jeff Law <law@redhat.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Richard Biener <richard.guenther@gmail.com>,
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCHv3] Vimrc config with GNU formatting
Date: Tue, 16 Sep 2014 21:59:00 -0000 [thread overview]
Message-ID: <20140916215858.GA20924@tsaunders-iceball.corp.tor1.mozilla.com> (raw)
In-Reply-To: <541867A2.6020405@samsung.com>
On Tue, Sep 16, 2014 at 08:38:58PM +0400, Yury Gribov wrote:
> Hi all,
>
> This is the third version of the patch. A list of changes since last
> version:
> * move config to contrib so that it's _not_ enabled by default (current
> score is 2/1 in favor of no Vim config by default)
fwiw, I think enabling it by default especially when that really means
enable it if you've enabled the localrc plugin makes sense. I don't see
how you can enable the localrc plugin and then complain when people use
it for its designed purpose. However something in contrib/ is probably
easier for new people to find than something on the wiki or something so
better than doing nothing :)
Thanks!
Trev
> * update Makefile.in to make .local.vimrc if developer asks for it
> * disable autoformatting for flex files
> * fix filtering of non-GNU sources (libsanitizer)
> * added some small fixes in cinoptions based on feedback from community
>
> As noted by Richard, the config does not do a good job of formatting unbound
> {} blocks e.g.
> void
> foo ()
> {
> int x;
> {
> // I'm an example of bad bad formatting
> }
> }
> but it seems to be the best we can get with Vim's cindent
> (and I don't think anyone seriously considers writing a custom indentexpr).
>
> Ok to commit?
>
> -Y
> commit 67219512dac9a5cc14eea8f157222a226044dd72
> Author: Yury Gribov <y.gribov@samsung.com>
> Date: Thu Sep 4 16:55:44 2014 +0400
>
> 2014-09-16 Laurynas Biveinis <laurynas.biveinis@gmail.com>
> Yury Gribov <y.gribov@samsung.com>
>
> Vim config with GNU formatting.
>
> contrib/
> * vimrc: New file.
>
> /
> * .gitignore: Added .local.vimrc.
> * Makefile.tpl (.local.vimrc): New target.
> * Makefile.in: Regenerate.
>
> diff --git a/.gitignore b/.gitignore
> index e9b56be..252b8b0 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -32,6 +32,8 @@ POTFILES
> TAGS
> TAGS.sub
>
> +.local.vimrc
> +
> .gdbinit
> .gdb_history
>
> diff --git a/Makefile.in b/Makefile.in
> index d6105b3..e573069 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -2384,6 +2384,11 @@ mail-report-with-warnings.log: warning.log
> chmod +x $@
> echo If you really want to send e-mail, run ./$@ now
>
> +# Local Vim config
> +
> +vimrc:
> + (cd $(srcdir); $(LN_S) contrib/vimrc .local.vimrc)
> +
> # Installation targets.
>
> .PHONY: install uninstall
> diff --git a/Makefile.tpl b/Makefile.tpl
> index f7c7e38..d050694 100644
> --- a/Makefile.tpl
> +++ b/Makefile.tpl
> @@ -867,6 +867,11 @@ mail-report-with-warnings.log: warning.log
> chmod +x $@
> echo If you really want to send e-mail, run ./$@ now
>
> +# Local Vim config
> +
> +vimrc:
> + (cd $(srcdir); $(LN_S) contrib/vimrc .local.vimrc)
> +
> # Installation targets.
>
> .PHONY: install uninstall
> diff --git a/contrib/vimrc b/contrib/vimrc
> new file mode 100644
> index 0000000..7287bd1
> --- /dev/null
> +++ b/contrib/vimrc
> @@ -0,0 +1,43 @@
> +" Code formatting settings for Vim.
> +"
> +" To enable this for GCC files by default, install thinca's localrc plugin
> +" and do
> +" $ make .local.vimrc
> +" Or if you dislike plugins, add autocmd in your .vimrc:
> +" :au BufNewFile,BufReadPost path/to/gcc/* :so path/to/gcc/.local.vimrc
> +" Or just source file manually every time if you are masochist:
> +" :so .local.vimrc
> +"
> +" Copyright (C) 2014 Free Software Foundation, Inc.
> +"
> +" This program is free software; you can redistribute it and/or modify
> +" it under the terms of the GNU General Public License as published by
> +" the Free Software Foundation; either version 3 of the License, or
> +" (at your option) any later version.
> +"
> +" This program is distributed in the hope that it will be useful,
> +" but WITHOUT ANY WARRANTY; without even the implied warranty of
> +" MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +" GNU General Public License for more details.
> +"
> +" You should have received a copy of the GNU General Public License
> +" along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +function! SetStyle()
> + let l:fname = expand("%:p")
> + if stridx(l:fname, 'libsanitizer') != -1
> + return
> + endif
> + let l:ext = fnamemodify(l:fname, ":e")
> + let l:c_exts = ['c', 'h', 'cpp', 'cc', 'C', 'H', 'def', 'java']
> + if index(l:c_exts, l:ext) != -1
> + setlocal cindent
> + setlocal shiftwidth=2
> + setlocal softtabstop=2
> + setlocal cinoptions=>2s,n-s,{s,^-s,:s,=s,g0,f0,hs,p2s,t0,+s,(0,u0,w1,m0
> + setlocal textwidth=79
> + setlocal formatoptions-=ro formatoptions+=cql
> + endif
> +endfunction
> +
> +call SetStyle()
next prev parent reply other threads:[~2014-09-16 21:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 13:06 Yury Gribov
2014-09-04 13:22 ` Richard Biener
2014-09-04 20:23 ` Bernhard Reutner-Fischer
2014-09-05 15:10 ` Yury Gribov
2014-09-05 16:46 ` Bernhard Reutner-Fischer
2014-09-06 16:33 ` Yury Gribov
2014-09-05 17:35 ` Segher Boessenkool
2014-09-06 15:40 ` Yury Gribov
2014-09-06 18:21 ` Trevor Saunders
2014-09-06 19:35 ` Segher Boessenkool
2014-09-07 4:18 ` Yuri Gribov
2014-09-07 4:48 ` Yuri Gribov
2014-09-07 13:33 ` Segher Boessenkool
2014-09-05 15:04 ` Yury Gribov
2014-09-10 8:09 ` [PATCHv2] " Yury Gribov
2014-09-10 8:17 ` Yury Gribov
2014-09-10 19:17 ` Segher Boessenkool
2014-09-11 4:47 ` Yury Gribov
2014-09-11 9:14 ` pinskia
2014-09-11 9:35 ` Yury Gribov
2014-09-11 9:06 ` Richard Biener
2014-09-11 9:18 ` Richard Biener
2014-09-11 10:10 ` Yury Gribov
2014-09-11 16:07 ` Yury Gribov
2014-09-14 10:32 ` Alexander Monakov
2014-09-15 9:54 ` Yury Gribov
2014-09-16 16:38 ` [PATCHv3] " Yury Gribov
2014-09-16 21:59 ` Trevor Saunders [this message]
2014-09-17 13:02 ` Segher Boessenkool
2014-09-17 14:05 ` Yury Gribov
2014-09-17 14:10 ` Yury Gribov
2014-09-17 17:08 ` [PATCHv4] " Yury Gribov
2014-09-18 3:54 ` Segher Boessenkool
2014-09-18 8:39 ` Yury Gribov
2014-09-18 15:37 ` Mike Stump
2014-09-18 17:20 ` Segher Boessenkool
2014-09-19 4:17 ` Yury Gribov
2014-09-19 11:11 ` Segher Boessenkool
2014-10-02 17:14 ` [PATCHv5] " Yury Gribov
2014-10-13 10:33 ` [PATCHv5][PING] " Yury Gribov
2014-10-21 15:24 ` [PATCHv5][PING^2] " Yury Gribov
2014-11-06 10:31 ` [PATCHv5][PING^3] " Yury Gribov
2014-11-28 18:00 ` [PATCHv5][PING^4] " Yury Gribov
2014-12-08 21:46 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916215858.GA20924@tsaunders-iceball.corp.tor1.mozilla.com \
--to=tsaunders@mozilla.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=laurynas.biveinis@gmail.com \
--cc=law@redhat.com \
--cc=mikestump@comcast.net \
--cc=rep.dot.nop@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).