From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-378448-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 345 invoked by alias); 23 Sep 2014 10:22:46 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 321 invoked by uid 89); 23 Sep 2014 10:22:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Sep 2014 10:22:39 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8NAMblf014039	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Tue, 23 Sep 2014 06:22:37 -0400
Received: from localhost (ovpn-116-40.ams2.redhat.com [10.36.116.40])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8NAMZMW024393;	Tue, 23 Sep 2014 06:22:36 -0400
Date: Tue, 23 Sep 2014 10:22:00 -0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Wollgast <patrick.wollgast@rub.de>
Cc: Caroline Tice <cmtice@google.com>, bkoz@gnu.org, ktietz@redhat.com,        GCC Patches <gcc-patches@gcc.gnu.org>, libstdc++@gcc.gnu.org
Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
Message-ID: <20140923102235.GJ2669@redhat.com>
References: <53FF0C8C.8090507@rub.de> <5411213F.1070104@rub.de> <CABtf2+RU7frwOXOX2FF8Tmfc6ssrpfFVj1Vuue4cZt19FpSWtQ@mail.gmail.com> <CABtf2+QWxvv1FUW_-kD3d0FBhYQWkZcPWAx8ASies_4j7thmoA@mail.gmail.com> <541B5B7E.2090300@rub.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <541B5B7E.2090300@rub.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2014-09/txt/msg01929.txt.bz2

On 19/09/14 00:23 +0200, Patrick Wollgast wrote:
>Index: libstdc++-v3/acinclude.m4
>===================================================================
>--- libstdc++-v3/acinclude.m4	(Revision 214408)
>+++ libstdc++-v3/acinclude.m4	(Arbeitskopie)
>@@ -2321,7 +2321,17 @@ AC_DEFUN([GLIBCXX_ENABLE_VTABLE_VERIFY],
>   AC_MSG_RESULT([$enable_vtable_verify])
> 
>   if test $enable_vtable_verify = yes; then
>+    case ${target_os} in
>+  cygwin*|mingw32*)
>+    VTV_CXXFLAGS="-fvtable-verify=std -Wl,-lvtv,-u_vtable_map_vars_start,-u_vtable_map_vars_end"
>+    vtv_cygmin="yes"
>+    ;;
>+  *)
>     VTV_CXXFLAGS="-fvtable-verify=std -Wl,-u_vtable_map_vars_start,-u_vtable_map_vars_end"
>+    vtv_cygmin="no"
>+    ;;
>+    esac
>+    AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
>     VTV_PCH_CXXFLAGS="-fvtable-verify=std"
>     VTV_CXXLINKFLAGS="-L${toplevel_builddir}/libvtv/.libs -Wl,--rpath -Wl,${toplevel_builddir}/libvtv/.libs"		
>   else

The lines between case and esac should be indented by four more
spaces.

Apart from that the libstdc++ changes are OK and I'll approve them.