From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1348 invoked by alias); 23 Sep 2014 15:43:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1332 invoked by uid 89); 23 Sep 2014 15:43:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Sep 2014 15:43:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8NFgxoG002466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 23 Sep 2014 11:42:59 -0400 Received: from tucnak.zalov.cz (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8NFgvqa031072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 23 Sep 2014 11:42:58 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s8NFgsiS016685; Tue, 23 Sep 2014 17:42:54 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s8NFgoGe016684; Tue, 23 Sep 2014 17:42:50 +0200 Date: Tue, 23 Sep 2014 15:43:00 -0000 From: Jakub Jelinek To: Segher Boessenkool , Bernd Schmidt , Andrew MacLeod , gcc-patches , richard.sandiford@arm.com Subject: Re: parallel check output changes? Message-ID: <20140923154250.GQ17454@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <541AD692.4030907@redhat.com> <20140918130109.GH17454@tucnak.redhat.com> <541AD880.7080703@redhat.com> <541AF451.3070406@redhat.com> <541B1710.8060809@codesourcery.com> <20140918173609.GM17454@tucnak.redhat.com> <20140918184455.GB28595@gate.crashing.org> <20140919093723.GA26414@gate.crashing.org> <87iokel5c0.fsf@e105548-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87iokel5c0.fsf@e105548-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg01991.txt.bz2 On Tue, Sep 23, 2014 at 04:33:19PM +0100, Richard Sandiford wrote: > FWIW, the \S+ thing was deliberate. When one test is run multiple times > with different options, those options aren't necessarily tried in > alphabetical order. The old sh/awk script therefore used just the test > name as the key and kept tests with the same name in the order that > they were encountered: > > /^(PASS|XPASS|FAIL|XFAIL|UNRESOLVED|WARNING|ERROR|UNSUPPORTED|UNTESTED|KFAIL):/ { > testname=\$2 > # Ugly hack for gfortran.dg/dg.exp > if ("$TOOL" == "gfortran" && testname ~ /^gfortran.dg\/g77\//) > testname="h"testname > } > > (note the "$2"). This means that the output of the script is in the same > order as it would be for non-parallel runs. I was following (or trying > to follow) that behaviour in the python script. My understanding was that the sh version sorts the testcase name followed by the full line and then removes whatever has been there before the PASS/XPASS etc., so while e.g. whether some test PASSed or FAILed etc. is then more important than the option, if two tests PASS, the options are still used for the sorting. Note that before the parallelization changes, usually the same test filename would be run all by a single runtest instance, so it really didn't matter that much. > Your patch instead sorts based on the full test name, including options, > which means that the output no longer matches what you'd get from a > non-parallel run. AFAICT, it also no longer matches what you'd get from > the .sh version. That might be OK, just thought I'd mention it. I'm afraid there is not enough info to reconstruct the order serial version has. Jakub