From: Jonathan Wakely <jwakely@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
libstdc++ <libstdc++@gcc.gnu.org>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
Tom Tromey <tom@tromey.com>
Subject: Re: [libstdc++] Refactor python/hook.in
Date: Mon, 29 Sep 2014 13:11:00 -0000 [thread overview]
Message-ID: <20140929131116.GB4197@redhat.com> (raw)
In-Reply-To: <CAGyQ6gyqMPZyJMN6326qtAzSTAAc1azodk5Jx3ZtMoFYM5puOQ@mail.gmail.com>
On 29/09/14 06:02 -0700, Siva Chandra wrote:
>The attached patch refactors python/hook.in so that there are no
>individual function calls to load pretty printers and xmethods. This
>was suggested by Tom here:
>https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02589.html. He indicates
>that it is better to put as little as possible in the hook file. The
>attached patch removes all code which explicitly loads the hooks from
>hook.in.
This looks good to me, thanks.
I'll commit it later this week unless I hear objections from Tom.
next prev parent reply other threads:[~2014-09-29 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 13:02 Siva Chandra
2014-09-29 13:11 ` Jonathan Wakely [this message]
2014-09-29 14:51 ` Tom Tromey
2014-09-30 15:34 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929131116.GB4197@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=sivachandra@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).