From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-379178-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 18280 invoked by alias); 30 Sep 2014 15:34:09 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 18261 invoked by uid 89); 30 Sep 2014 15:34:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Sep 2014 15:34:07 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8UFY3Cw009407	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Tue, 30 Sep 2014 11:34:04 -0400
Received: from localhost (ovpn-116-114.ams2.redhat.com [10.36.116.114])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8UFY2eD017942;	Tue, 30 Sep 2014 11:34:02 -0400
Date: Tue, 30 Sep 2014 15:34:00 -0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, libstdc++ <libstdc++@gcc.gnu.org>,        Jonathan Wakely <jwakely.gcc@gmail.com>, Tom Tromey <tom@tromey.com>
Subject: Re: [libstdc++] Refactor python/hook.in
Message-ID: <20140930153402.GL4197@redhat.com>
References: <CAGyQ6gyqMPZyJMN6326qtAzSTAAc1azodk5Jx3ZtMoFYM5puOQ@mail.gmail.com> <20140929131116.GB4197@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20140929131116.GB4197@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2014-09/txt/msg02659.txt.bz2

On 29/09/14 14:11 +0100, Jonathan Wakely wrote:
>On 29/09/14 06:02 -0700, Siva Chandra wrote:
>>The attached patch refactors python/hook.in so that there are no
>>individual function calls to load pretty printers and xmethods. This
>>was suggested by Tom here:
>>https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02589.html. He indicates
>>that it is better to put as little as possible in the hook file. The
>>attached patch removes all code which explicitly loads the hooks from
>>hook.in.
>
>This looks good to me, thanks.
>
>I'll commit it later this week unless I hear objections from Tom.

Committed to trunk - thanks for the patch.