public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Segher Boessenkool <segher@kernel.crashing.org>,
	       Andrew MacLeod <amacleod@redhat.com>,
	       Bernd Schmidt <bernds@codesourcery.com>,
	       gcc-patches <gcc-patches@gcc.gnu.org>,
	richard.sandiford@arm.com,        rdsandiford@googlemail.com
Subject: Re: parallel check output changes?
Date: Thu, 02 Oct 2014 18:00:00 -0000	[thread overview]
Message-ID: <20141002175950.GJ1986@tucnak.redhat.com> (raw)
In-Reply-To: <871tqqnz4k.fsf@googlemail.com>

On Thu, Oct 02, 2014 at 06:46:19PM +0100, Richard Sandiford wrote:
> Segher Boessenkool <segher@kernel.crashing.org> writes:
> > On Wed, Sep 24, 2014 at 10:54:57AM -0400, Andrew MacLeod wrote:
> >> Is this suppose to be resolved now?  I'm still seeing some issues with a 
> >> branch cut from mainline from yesterday.
> >
> > Confirmed.  The following patch works for me, and Andrew has tested it
> > as well.  The comment it removes isn't valid before the patch either.
> 
> I get the impression from a short dismissal like that that this script
> is pretty hated :-(.  Remember that originally the script was trying to

No, it is certainly appreciated that it speeded up the processing.

> make the result of combining separate .sum files the same as the .sum
> file you'd get for -j1.  As Jakub said upthread, that's a lost cause
> with the new approach to parallel testing, but I think the comment was
> valid while matching -j1 was still a goal.

I'm sorry for invalidating those assumptions.  Indeed, before my recent
changes, all tests for the same testcase name were run serially by the same
job.  If we wanted to preserve that property, we could e.g. store the
results of gcc_parallel_test_run_p in some tcl array with testcase as the
key, and after the
        if { $gcc_runtest_parallelize_enable == 0 } {
            return 1
        }
test add a test if we've been asked about a particular testcase already,
just return what we've returned before.  Perhaps accompany that with
lowering the granularity (e.g. from 10 to 5).

	Jakub

  reply	other threads:[~2014-10-02 18:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 12:56 Andrew MacLeod
2014-09-18 13:08 ` Jakub Jelinek
2014-09-18 13:05   ` Andrew MacLeod
2014-09-18 15:45     ` Andrew MacLeod
2014-09-18 17:33       ` Bernd Schmidt
2014-09-18 17:36         ` Jakub Jelinek
2014-09-18 18:45           ` Segher Boessenkool
2014-09-19  9:37             ` Segher Boessenkool
2014-09-19 16:32               ` Mike Stump
2014-09-23 15:33               ` Richard Sandiford
2014-09-23 15:43                 ` Jakub Jelinek
2014-09-24 14:55                 ` Andrew MacLeod
2014-09-24 16:11                   ` Segher Boessenkool
2014-09-24 16:29                     ` Andrew MacLeod
2014-09-24 17:59                       ` Andrew MacLeod
2014-09-25 12:22                         ` Andrew MacLeod
2014-09-25 17:02                           ` Segher Boessenkool
2014-10-02 16:47                   ` Segher Boessenkool
2014-10-02 17:05                     ` Jakub Jelinek
2014-10-02 17:46                     ` Richard Sandiford
2014-10-02 18:00                       ` Jakub Jelinek [this message]
2014-10-04 10:32                         ` Richard Sandiford
2014-10-05 17:53                           ` Mike Stump
2014-10-02 18:15                       ` Segher Boessenkool
2014-10-02 19:05                         ` Andrew MacLeod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002175950.GJ1986@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=bernds@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rdsandiford@googlemail.com \
    --cc=richard.sandiford@arm.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).