From: Jakub Jelinek <jakub@redhat.com>
To: Ilya Verbin <iverbin@gmail.com>
Cc: Cary Coutant <ccoutant@google.com>,
Richard Biener <rguenther@suse.de>,
Jan Hubicka <hubicka@ucw.cz>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Thomas Schwinge <thomas@codesourcery.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Andrey Turetskiy <andrey.turetskiy@gmail.com>
Subject: Re: [PATCH 4/n] OpenMP 4.0 offloading infrastructure: lto-wrapper
Date: Tue, 14 Oct 2014 09:41:00 -0000 [thread overview]
Message-ID: <20141014094009.GX10376@tucnak.redhat.com> (raw)
In-Reply-To: <20141013224247.GA61615@msticlxl57.ims.intel.com>
On Tue, Oct 14, 2014 at 02:42:47AM +0400, Ilya Verbin wrote:
> > For that I guess
> > lhd_begin_section
> > would need to replace:
> > section = get_section (name, SECTION_DEBUG, NULL);
> > with:
> > section = get_section (name, SECTION_DEBUG | SECTION_EXCLUDE, NULL);
> > either just for the .gnu.offload_lto prefixed section, or all.
> > The question is what will old assemblers and/or linkers do with that, and
> > if there are any that support linker plugins, but not SHF_EXCLUDE.
>
> I've tried to set SECTION_EXCLUDE bit with as+ld version 2.20.51 and got a lot
> of warnings like:
>
> /tmp/ccg7P7iS.s:2: Warning: entity size for SHF_MERGE not specified
> /tmp/ccg7P7iS.s:2: Warning: group name for SHF_GROUP not specified
> as: /tmp/ccKFKXfc.o: warning: sh_link not set for section `.gnu.lto_main.11d9780ff2ebf166'
> /usr/bin/ld: /tmp/ccKFKXfc.o: warning: sh_link not set for section `.gnu.lto_main.11d9780ff2ebf166'
>
> I think, it can be placed under such ifdef:
>
> #if defined (HAVE_SECTION_EXCLUDE) && HAVE_SECTION_EXCLUDE == 1
> section = get_section (name, SECTION_DEBUG | SECTION_EXCLUDE, NULL);
> #else
> section = get_section (name, SECTION_DEBUG, NULL);
> #endif
>
> Currently there is HAVE_GAS_SECTION_EXCLUDE implemented in gcc/configure.ac, and
> HAVE_SECTION_EXCLUDE can use it + check a version of the linker.
My preference would be to add the | SECTION_EXCLUDE unconditionally, and
instead guard the
if (flags & SECTION_EXCLUDE)
*f++ = 'e';
in varasm.c (default_elf_asm_named_section). The only other user of
SECTION_EXCLUDE seems to be -gsplit-dwarf right now, Cary, is such a change
ok with you?
If you have new gas and old linker, I'd expect it would just ignore
SHF_EXCLUDE.
Jakub
next prev parent reply other threads:[~2014-10-14 9:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 15:15 Ilya Verbin
2014-10-08 10:27 ` Jakub Jelinek
2014-10-09 12:09 ` Ilya Verbin
2014-10-09 12:13 ` Bernd Schmidt
2014-10-09 20:27 ` Ilya Verbin
2014-10-10 7:13 ` Jakub Jelinek
2014-10-10 16:52 ` Cary Coutant
2014-10-10 17:01 ` Jakub Jelinek
2014-10-10 17:10 ` Cary Coutant
2014-10-13 22:47 ` Ilya Verbin
2014-10-14 9:41 ` Jakub Jelinek [this message]
2014-10-15 14:27 ` Ilya Verbin
2014-10-15 14:46 ` Jakub Jelinek
2014-10-16 11:18 ` Ilya Verbin
2014-10-16 11:27 ` Jakub Jelinek
2014-10-29 10:28 ` Kirill Yukhin
2014-11-06 13:00 ` Ilya Verbin
2014-11-12 9:47 ` Richard Biener
2014-10-15 17:03 ` Cary Coutant
2015-05-12 16:32 ` Thomas Schwinge
2015-05-12 17:19 ` Bernd Schmidt
2015-10-02 21:28 ` Help the offload gcc driver find the right assembler (was: [PATCH 4/n] OpenMP 4.0 offloading infrastructure: lto-wrapper) Thomas Schwinge
2016-02-19 19:42 ` [PATCH 4/n] OpenMP 4.0 offloading infrastructure: lto-wrapper Thomas Schwinge
2016-02-19 19:51 ` Ilya Verbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014094009.GX10376@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=andrey.turetskiy@gmail.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=iverbin@gmail.com \
--cc=kirill.yukhin@gmail.com \
--cc=rguenther@suse.de \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).