From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12211 invoked by alias); 15 Oct 2014 15:28:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12196 invoked by uid 89); 15 Oct 2014 15:28:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f178.google.com Received: from mail-lb0-f178.google.com (HELO mail-lb0-f178.google.com) (209.85.217.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Oct 2014 15:28:52 +0000 Received: by mail-lb0-f178.google.com with SMTP id w7so1276020lbi.9 for ; Wed, 15 Oct 2014 08:28:48 -0700 (PDT) X-Received: by 10.153.5.33 with SMTP id cj1mr13265760lad.36.1413386928521; Wed, 15 Oct 2014 08:28:48 -0700 (PDT) Received: from msticlxl57.ims.intel.com (fmdmzpr01-ext.fm.intel.com. [192.55.54.36]) by mx.google.com with ESMTPSA id dc5sm2509850lbd.24.2014.10.15.08.28.44 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Oct 2014 08:28:47 -0700 (PDT) Date: Wed, 15 Oct 2014 15:35:00 -0000 From: Ilya Verbin To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Bernd Schmidt , Thomas Schwinge , Kirill Yukhin , Andrey Turetskiy Subject: Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite Message-ID: <20141015152837.GC46277@msticlxl57.ims.intel.com> References: <20141015145752.GB46277@msticlxl57.ims.intel.com> <20141015150543.GR10376@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141015150543.GR10376@tucnak.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01371.txt.bz2 On 15 Oct 17:05, Jakub Jelinek wrote: > > This patch adds all examples with '#pragma omp target' from [1] to libgomp > > testsuite. Without an accelerator or emulator, these tests are UNSUPPORTED. > > Why? Most of the tests should work just fine with host fallback. > Yeah, from Examples 4.0.1 I'm aware of some tests which assume that host > fallback doesn't happen, but they should be in minority. > So, can you temporarily change check_effective_target_offload_device to > always return 0 from main, run the testsuite with OMP_DEFAULT_DEVICE=10000 > in the environment and see what testcases really need > { dg-require-effective-target offload_device } ? Yes, they will work fine with host fallback, however we want to be sure that tests are running on device (or emulator). If there were some issue with offloading, and a test actually were running in fallback mode, we would never know about it. That's why we added dg-require-effective-target to all tests. Thanks, -- Ilya