public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][0/n] Merge from match-and-simplify
Date: Wed, 15 Oct 2014 17:13:00 -0000	[thread overview]
Message-ID: <20141015170638.GY10376@tucnak.redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1410151450430.20733@zhemvz.fhfr.qr>

On Wed, Oct 15, 2014 at 03:00:57PM +0200, Richard Biener wrote:
> To re-iterate here (as I expect most people will only look
> at [0/n] patches ;)), the question is whether we are fine
> with making fold-const (thus fold_{unary,binary,ternary})
> not handle some cases it handles currently.

I'd say not dealing with side-effects should be smaller problem
than looking through casts etc., expressions with side-effects
generally shouldn't be folding into constants, where I'd expect the highest
risks (something previously folded into constants and used in initializers
not working any longer, or __builtin_constant_p, etc.).

I'd say just trying hard not to regress, and adding testsuite coverage
where not already covered, should be good enough, if something important
regresses, hopefully mass rebuilds will reveal it or users report it to us.

	Jakub

  parent reply	other threads:[~2014-10-15 17:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 13:20 Richard Biener
2014-10-15 16:30 ` Kyrill Tkachov
2014-10-17  7:39   ` Ramana Radhakrishnan
2014-10-17  8:24     ` Richard Biener
2014-10-17 11:58       ` Richard Biener
2014-10-15 17:13 ` Jakub Jelinek [this message]
2014-10-16 20:43 ` Sebastian Pop
2014-10-16 20:50   ` Andrew Pinski
2014-10-17  7:29     ` Ramana Radhakrishnan
2014-10-17  8:00   ` Richard Biener
2014-10-17 16:44     ` Sebastian Pop
2014-10-17 17:37       ` Richard Biener
2014-10-17 18:32       ` Sebastian Pop
2014-10-20 11:47         ` Richard Biener
2014-10-22 21:06           ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015170638.GY10376@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).