From: Jan Hubicka <hubicka@ucw.cz>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [patch] Fix ICE during LTRANS on big Ada application
Date: Wed, 15 Oct 2014 20:06:00 -0000 [thread overview]
Message-ID: <20141015200409.GB21865@kam.mff.cuni.cz> (raw)
In-Reply-To: <2240629.yAX7Fe0x2x@polaris>
> Jan, any opinion on the following patch?
>
> > 2014-10-06 Eric Botcazou <ebotcazou@adacore.com>
> >
> > * ipa-inline-transform.c (can_remove_node_now_p_1): Return false for a
> > master clone that has non-inline clones.
>
> https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00436.html
>
> Thanks in advance.
Yes, this looks OK. Inliner coul also take care to turn the master clone into unanalyzed
node as remove_unreachable_nodes would, but I do not think it is worth the effort.
Please put the loop later in the function so it does not slow things down unnecesarily
(there are often many inline clones)
Honza
>
> --
> Eric Botcazou
next prev parent reply other threads:[~2014-10-15 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 10:30 Eric Botcazou
2014-10-15 18:06 ` Eric Botcazou
2014-10-15 20:06 ` Jan Hubicka [this message]
2014-10-16 15:15 ` Eric Botcazou
2014-10-17 20:02 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015200409.GB21865@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).