From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6456 invoked by alias); 15 Oct 2014 20:04:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6446 invoked by uid 89); 15 Oct 2014 20:04:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Oct 2014 20:04:13 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id B521E541289; Wed, 15 Oct 2014 22:04:09 +0200 (CEST) Date: Wed, 15 Oct 2014 20:06:00 -0000 From: Jan Hubicka To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Jan Hubicka Subject: Re: [patch] Fix ICE during LTRANS on big Ada application Message-ID: <20141015200409.GB21865@kam.mff.cuni.cz> References: <15700032.Vfff8vmhaG@polaris> <2240629.yAX7Fe0x2x@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2240629.yAX7Fe0x2x@polaris> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-10/txt/msg01429.txt.bz2 > Jan, any opinion on the following patch? > > > 2014-10-06 Eric Botcazou > > > > * ipa-inline-transform.c (can_remove_node_now_p_1): Return false for a > > master clone that has non-inline clones. > > https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00436.html > > Thanks in advance. Yes, this looks OK. Inliner coul also take care to turn the master clone into unanalyzed node as remove_unreachable_nodes would, but I do not think it is worth the effort. Please put the loop later in the function so it does not slow things down unnecesarily (there are often many inline clones) Honza > > -- > Eric Botcazou