* [flag-types.h] don't assume 32-bit ints
@ 2014-10-15 22:29 DJ Delorie
2014-10-16 7:08 ` Jakub Jelinek
0 siblings, 1 reply; 3+ messages in thread
From: DJ Delorie @ 2014-10-15 22:29 UTC (permalink / raw)
To: gcc-patches
Since flag-types.h is used in target code, it needs to be -Wall-safe
for targets with 16-bit "int". OK?
Index: gcc/flag-types.h
===================================================================
--- gcc/flag-types.h (revision 216287)
+++ gcc/flag-types.h (working copy)
@@ -229,17 +229,17 @@ enum sanitize_code {
SANITIZE_RETURN = 1 << 10,
SANITIZE_SI_OVERFLOW = 1 << 11,
SANITIZE_BOOL = 1 << 12,
SANITIZE_ENUM = 1 << 13,
SANITIZE_FLOAT_DIVIDE = 1 << 14,
SANITIZE_FLOAT_CAST = 1 << 15,
- SANITIZE_BOUNDS = 1 << 16,
- SANITIZE_ALIGNMENT = 1 << 17,
- SANITIZE_NONNULL_ATTRIBUTE = 1 << 18,
- SANITIZE_RETURNS_NONNULL_ATTRIBUTE = 1 << 19,
- SANITIZE_OBJECT_SIZE = 1 << 20,
+ SANITIZE_BOUNDS = 1UL << 16,
+ SANITIZE_ALIGNMENT = 1UL << 17,
+ SANITIZE_NONNULL_ATTRIBUTE = 1UL << 18,
+ SANITIZE_RETURNS_NONNULL_ATTRIBUTE = 1UL << 19,
+ SANITIZE_OBJECT_SIZE = 1UL << 20,
SANITIZE_UNDEFINED = SANITIZE_SHIFT | SANITIZE_DIVIDE | SANITIZE_UNREACHABLE
| SANITIZE_VLA | SANITIZE_NULL | SANITIZE_RETURN
| SANITIZE_SI_OVERFLOW | SANITIZE_BOOL | SANITIZE_ENUM
| SANITIZE_BOUNDS | SANITIZE_ALIGNMENT
| SANITIZE_NONNULL_ATTRIBUTE
| SANITIZE_RETURNS_NONNULL_ATTRIBUTE
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [flag-types.h] don't assume 32-bit ints
2014-10-15 22:29 [flag-types.h] don't assume 32-bit ints DJ Delorie
@ 2014-10-16 7:08 ` Jakub Jelinek
2014-10-16 21:06 ` DJ Delorie
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Jelinek @ 2014-10-16 7:08 UTC (permalink / raw)
To: DJ Delorie; +Cc: gcc-patches
On Wed, Oct 15, 2014 at 06:16:45PM -0400, DJ Delorie wrote:
>
> Since flag-types.h is used in target code, it needs to be -Wall-safe
> for targets with 16-bit "int". OK?
With a ChangeLog entry yes.
> --- gcc/flag-types.h (revision 216287)
> +++ gcc/flag-types.h (working copy)
> @@ -229,17 +229,17 @@ enum sanitize_code {
> SANITIZE_RETURN = 1 << 10,
> SANITIZE_SI_OVERFLOW = 1 << 11,
> SANITIZE_BOOL = 1 << 12,
> SANITIZE_ENUM = 1 << 13,
> SANITIZE_FLOAT_DIVIDE = 1 << 14,
> SANITIZE_FLOAT_CAST = 1 << 15,
> - SANITIZE_BOUNDS = 1 << 16,
> - SANITIZE_ALIGNMENT = 1 << 17,
> - SANITIZE_NONNULL_ATTRIBUTE = 1 << 18,
> - SANITIZE_RETURNS_NONNULL_ATTRIBUTE = 1 << 19,
> - SANITIZE_OBJECT_SIZE = 1 << 20,
> + SANITIZE_BOUNDS = 1UL << 16,
> + SANITIZE_ALIGNMENT = 1UL << 17,
> + SANITIZE_NONNULL_ATTRIBUTE = 1UL << 18,
> + SANITIZE_RETURNS_NONNULL_ATTRIBUTE = 1UL << 19,
> + SANITIZE_OBJECT_SIZE = 1UL << 20,
> SANITIZE_UNDEFINED = SANITIZE_SHIFT | SANITIZE_DIVIDE | SANITIZE_UNREACHABLE
> | SANITIZE_VLA | SANITIZE_NULL | SANITIZE_RETURN
> | SANITIZE_SI_OVERFLOW | SANITIZE_BOOL | SANITIZE_ENUM
> | SANITIZE_BOUNDS | SANITIZE_ALIGNMENT
> | SANITIZE_NONNULL_ATTRIBUTE
> | SANITIZE_RETURNS_NONNULL_ATTRIBUTE
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [flag-types.h] don't assume 32-bit ints
2014-10-16 7:08 ` Jakub Jelinek
@ 2014-10-16 21:06 ` DJ Delorie
0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2014-10-16 21:06 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
> With a ChangeLog entry yes.
Thanks! Committed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-16 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-15 22:29 [flag-types.h] don't assume 32-bit ints DJ Delorie
2014-10-16 7:08 ` Jakub Jelinek
2014-10-16 21:06 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).