public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	       Richard Biener <richard.guenther@gmail.com>
Subject: Re: PR debug/60655, debug loc expressions
Date: Thu, 16 Oct 2014 07:20:00 -0000	[thread overview]
Message-ID: <20141016070758.GF10376@tucnak.redhat.com> (raw)
In-Reply-To: <20141016065557.GJ4267@bubble.grove.modra.org>

On Thu, Oct 16, 2014 at 05:25:57PM +1030, Alan Modra wrote:
> Ping?
> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00704.html

I think the simplification should be done when constructing the expressions,
i.e. if possible in the simplification callback or so if it isn't
performed at some level.
Because otherwise, you construct the RTL all the way up into complex
expressions, and then another simplification will, if there are
simplifications e.g. very deep in the expressions, copy the rest all the way
up, creating tons of GC garbage.
So, please find the spot where we forget to simplify stuff, and put the
simplification there.

	Jakub

  reply	other threads:[~2014-10-16  7:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 10:29 [PATCH][PR debug/60655] Power/GCC: Reject cross-section symbol subtraction Maciej W. Rozycki
     [not found] ` <CAGWvnyk61JeAUVBogq5uf5gDQzqkj+-VTuNag1FMb=h6ttNztg@mail.gmail.com>
2014-09-03  5:31   ` Alan Modra
2014-09-04 12:22     ` Alan Modra
2014-09-04 21:05       ` Maciej W. Rozycki
2014-09-05  1:30         ` Alan Modra
2014-09-09 11:50           ` PR debug/60655, debug loc expressions Alan Modra
2014-09-09 14:25             ` Richard Biener
2014-09-09 14:31               ` Jakub Jelinek
2014-09-09 14:42                 ` Richard Biener
2014-09-10  2:16                   ` Alan Modra
2014-10-16  6:56                     ` Alan Modra
2014-10-16  7:20                       ` Jakub Jelinek [this message]
2014-10-20 10:55                         ` Alan Modra
2014-10-20 11:19                           ` Jakub Jelinek
2014-10-23  7:09                             ` Fix 63615 - FAIL: gcc.target/i386/addr-sel-1.c Alan Modra
2014-10-24 19:39                               ` Jeff Law
2014-10-24 23:33                           ` PR debug/60655, debug loc expressions Maciej W. Rozycki
2014-09-10 12:43             ` Maciej W. Rozycki
2014-09-10 13:09               ` Alan Modra
2014-09-10 13:27                 ` Maciej W. Rozycki
2014-09-10 16:09               ` Ramana Radhakrishnan
2014-09-10 17:27                 ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141016070758.GF10376@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).