From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-380756-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4236 invoked by alias); 16 Oct 2014 11:15:38 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 4220 invoked by uid 89); 16 Oct 2014 11:15:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 16 Oct 2014 11:15:35 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9GBFYDm018266	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Thu, 16 Oct 2014 07:15:34 -0400
Received: from tucnak.zalov.cz (ovpn-116-116.ams2.redhat.com [10.36.116.116])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9GBFWnG006187	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);	Thu, 16 Oct 2014 07:15:34 -0400
Received: from tucnak.zalov.cz (localhost [127.0.0.1])	by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id s9GBFVF9015995;	Thu, 16 Oct 2014 13:15:31 +0200
Received: (from jakub@localhost)	by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id s9GBFTss015994;	Thu, 16 Oct 2014 13:15:29 +0200
Date: Thu, 16 Oct 2014 11:18:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, Kirill Yukhin <kirill.yukhin@gmail.com>,        Richard Henderson <rth@redhat.com>,        GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH i386 AVX512] [63.1/n] Add vpshufb, perm autogen (except for v64qi).
Message-ID: <20141016111529.GE10376@tucnak.redhat.com>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <20141006125527.GC13369@msticlxl57.ims.intel.com> <20141006141035.GZ1986@tucnak.redhat.com> <20141009121523.GB81768@msticlxl7.ims.intel.com> <20141009185105.GM1986@tucnak.redhat.com> <20141010154719.GA121201@msticlxl7.ims.intel.com> <CAFULd4bGehNdNGtZOt+UE50ShHxbL-Xxfv4rNhwPD1sByDjyag@mail.gmail.com> <20141016102316.GA30455@msticlxl7.ims.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141016102316.GA30455@msticlxl7.ims.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg01531.txt.bz2

On Thu, Oct 16, 2014 at 02:23:16PM +0400, Ilya Tocar wrote:
> On 10 Oct 18:37, Uros Bizjak wrote:
> > On Fri, Oct 10, 2014 at 5:47 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> > 
> > 
> > Please recode that horrible first switch statement to:
> > 
> > --cut here--
> >   rtx (*gen) (rtx, rtx, rtx, rtx) = NULL;
> > 
> >   switch (mode)
> >     {
> >     case V8HImode:
> >       if (TARGET_AVX512VL && TARGET_AVX152BW)
> >     gen = gen_avx512vl_vpermi2varv8hi3;
> >       break;
> > 
> >     ...
> > 
> >     case V2DFmode:
> >       if (TARGET_AVX512VL)
> >     {
> >       gen = gen_avx512vl_vpermi2varv2df3;
> >       maskmode = V2DImode;
> > 
> > The patch is OK with the above improvement.
> > 
> > Thanks,
> > Uros.
> >
> 
> Will commit version below, if no objections in 24 hours.

No need to wait, it is ok now (with proper ChangeLog of course).

	Jakub