From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13701 invoked by alias); 17 Oct 2014 15:29:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13685 invoked by uid 89); 17 Oct 2014 15:29:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f182.google.com Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 17 Oct 2014 15:29:39 +0000 Received: by mail-wi0-f182.google.com with SMTP id n3so1575914wiv.9 for ; Fri, 17 Oct 2014 08:29:36 -0700 (PDT) X-Received: by 10.180.218.230 with SMTP id pj6mr14519419wic.62.1413559776339; Fri, 17 Oct 2014 08:29:36 -0700 (PDT) Received: from msticlxl57.ims.intel.com (fmdmzpr04-ext.fm.intel.com. [192.55.55.39]) by mx.google.com with ESMTPSA id o1sm2056724wja.25.2014.10.17.08.29.32 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Oct 2014 08:29:35 -0700 (PDT) Date: Fri, 17 Oct 2014 15:34:00 -0000 From: Ilya Verbin To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Bernd Schmidt , Thomas Schwinge , Kirill Yukhin , Andrey Turetskiy Subject: Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite Message-ID: <20141017152926.GD28310@msticlxl57.ims.intel.com> References: <20141015145752.GB46277@msticlxl57.ims.intel.com> <20141015150543.GR10376@tucnak.redhat.com> <20141015152837.GC46277@msticlxl57.ims.intel.com> <20141015153518.GS10376@tucnak.redhat.com> <20141017140211.GA28310@msticlxl57.ims.intel.com> <20141017141455.GY10376@tucnak.redhat.com> <20141017145817.GB28310@msticlxl57.ims.intel.com> <20141017151054.GC10376@tucnak.redhat.com> <20141017151731.GC28310@msticlxl57.ims.intel.com> <20141017151838.GD10376@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141017151838.GD10376@tucnak.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01751.txt.bz2 On 17 Oct 17:18, Jakub Jelinek wrote: > On Fri, Oct 17, 2014 at 07:17:31PM +0400, Ilya Verbin wrote: > > On 17 Oct 17:10, Jakub Jelinek wrote: > > > Well, there is no need to remove them, just the " || (f && !omp_is_initial_device ())" > > > should be dropped from target regions without device (d) on them. > > > Where there is no f && guard, the condition should stay. > > > Do you agree? > > > > Yes, should I re-post the patch? > > Guess just the target-7.c patch is enough, to make sure we agree on the same > thing. Here it is: diff --git a/libgomp/testsuite/libgomp.c/target-7.c b/libgomp/testsuite/libgomp.c/target-7.c index 90de6c5..0fe6150 100644 --- a/libgomp/testsuite/libgomp.c/target-7.c +++ b/libgomp/testsuite/libgomp.c/target-7.c @@ -18,7 +18,7 @@ foo (int f) if (omp_get_level () != 0 || !omp_is_initial_device ()) abort (); #pragma omp target if (v <= 1) - if (omp_get_level () != 0 || (f && !omp_is_initial_device ())) + if (omp_get_level () != 0) abort (); #pragma omp target device (d) if (v <= 1) if (omp_get_level () != 0 || (f && !omp_is_initial_device ())) @@ -30,7 +30,7 @@ foo (int f) if (omp_get_level () != 0 || !omp_is_initial_device ()) abort (); #pragma omp target if (1) - if (omp_get_level () != 0 || (f && !omp_is_initial_device ())) + if (omp_get_level () != 0) abort (); #pragma omp target device (d) if (1) if (omp_get_level () != 0 || (f && !omp_is_initial_device ())) @@ -59,7 +59,7 @@ foo (int f) #pragma omp target data if (v <= 1) map (to: h) { #pragma omp target if (v <= 1) - if (omp_get_level () != 0 || (f && !omp_is_initial_device ()) || h++ != 8) + if (omp_get_level () != 0 || h++ != 8) abort (); #pragma omp target update if (v <= 1) from (h) } @@ -87,7 +87,7 @@ foo (int f) #pragma omp target data if (1) map (to: h) { #pragma omp target if (1) - if (omp_get_level () != 0 || (f && !omp_is_initial_device ()) || h++ != 12) + if (omp_get_level () != 0 || h++ != 12) abort (); #pragma omp target update if (1) from (h) } -- Ilya