From: Jakub Jelinek <jakub@redhat.com>
To: Kirill Yukhin <kirill.yukhin@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>,
Richard Henderson <rth@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH i386 AVX512] [81/n] Add new built-ins.
Date: Mon, 20 Oct 2014 13:56:00 -0000 [thread overview]
Message-ID: <20141020135019.GP10376@tucnak.redhat.com> (raw)
In-Reply-To: <20141020134122.GB12661@msticlxl57.ims.intel.com>
On Mon, Oct 20, 2014 at 05:41:25PM +0400, Kirill Yukhin wrote:
> Hello,
> This patch adds (almost) all built-ins needed by
> AVX-512VL,BW,DQ intrinsics.
>
> Main questionable hunk is:
>
> diff --git a/gcc/tree-core.h b/gcc/tree-core.h
> index b69312b..a639487 100644
> --- a/gcc/tree-core.h
> +++ b/gcc/tree-core.h
> @@ -1539,7 +1539,7 @@ struct GTY(()) tree_function_decl {
> DECL_FUNCTION_CODE. Otherwise unused.
> ??? The bitfield needs to be able to hold all target function
> codes as well. */
> - ENUM_BITFIELD(built_in_function) function_code : 11;
> + ENUM_BITFIELD(built_in_function) function_code : 12;
> ENUM_BITFIELD(built_in_class) built_in_class : 2;
>
> unsigned static_ctor_flag : 1;
Well, decl_with_vis has 15 unused bits, so instead of growing
FUNCTION_DECL significantly, might be better to move one of the
flags to decl_with_vis and just document that it applies to FUNCTION_DECLs
only. Or move some flag to cgraph if possible.
But seeing e.g.
IX86_BUILTIN_FIXUPIMMPD256, IX86_BUILTIN_FIXUPIMMPD256_MASK,
IX86_BUILTIN_FIXUPIMMPD256_MASKZ
etc. I wonder if you really need that many builtins, weren't we adding
for avx512f just single builtin instead of 3 different ones, always
providing mask argument and depending on whether it is all ones, etc.
figuring out what kind of masking should be performed?
Jakub
next prev parent reply other threads:[~2014-10-20 13:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 13:50 Kirill Yukhin
2014-10-20 13:56 ` Jakub Jelinek [this message]
2014-10-21 9:19 ` Richard Biener
2014-10-21 14:19 ` Kirill Yukhin
2014-10-21 14:09 ` Kirill Yukhin
2014-10-21 14:21 ` Jakub Jelinek
2014-10-21 14:52 ` Kirill Yukhin
2014-10-21 15:13 ` Kirill Yukhin
2014-10-22 8:18 ` Richard Biener
2014-10-22 11:40 ` Kirill Yukhin
2014-10-22 11:43 ` Jakub Jelinek
2014-10-22 7:57 ` [PATCH AVX512] [81.1/n] Extend `function_code' field in `tree_var_decl' structure Kirill Yukhin
2014-10-23 11:10 ` Jakub Jelinek
2014-10-21 14:24 ` [PATCH i386 AVX512] [81/n] Add new built-ins Richard Biener
2014-10-23 12:58 ` [PATCH i386 AVX512] [81.2/n] " Kirill Yukhin
2014-10-23 13:46 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020135019.GP10376@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kirill.yukhin@gmail.com \
--cc=rth@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).