From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix genmatch linking
Date: Thu, 23 Oct 2014 15:27:00 -0000 [thread overview]
Message-ID: <20141023143811.GN10376@tucnak.redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1410231629460.9891@zhemvz.fhfr.qr>
On Thu, Oct 23, 2014 at 04:31:36PM +0200, Richard Biener wrote:
>
> Final try for today.
>
> Richard.
>
> Index: gcc/Makefile.in
> ===================================================================
> --- gcc/Makefile.in (revision 216590)
> +++ gcc/Makefile.in (working copy)
> @@ -981,7 +981,15 @@ else
> LIBIBERTY = ../libiberty/libiberty.a
> BUILD_LIBIBERTY = $(build_libobjdir)/libiberty/libiberty.a
> endif
> +# For stage1 and when cross-compiling use the build libcpp which is
> +# built with NLS disabled. For stage2+ use the host library and
> +# its dependencies.
> +ifeq ($(build_objdir),$(build_libobjdir))
> BUILD_CPPLIB = $(build_libobjdir)/libcpp/libcpp.a
> +else
> +BUILD_CPPLIB = $(CPPLIB) $(LIBIBERTY) $(LIBINTL) $(LIBICONV) $(LIBINTL_DEP) $(LIBICONV_DEP)
The $(LIBINTL_DEP) $(LIBICONV_DEP) on the above line is unnecessary IMHO,
# Rule for the generator programs:
$(genprog:%=build/gen%$(build_exeext)): build/gen%$(build_exeext): build/gen%.o $(BUILD_LIBDEPS)
+$(LINKER_FOR_BUILD) $(BUILD_LINKERFLAGS) $(BUILD_LDFLAGS) -o $@ \
$(filter-out $(BUILD_LIBDEPS), $^) $(BUILD_LIBS)
adds that automatically.
> +build/genmatch$(build_exeext): BUILD_LIBDEPS += $(LIBINTL_DEP) $(LIBICONV_DEP)
Here it is needed supposedly.
> +endif
>
> # Dependencies on the intl and portability libraries.
> LIBDEPS= libcommon.a $(CPPLIB) $(LIBIBERTY) $(LIBINTL_DEP) $(LIBICONV_DEP) \
Jakub
next prev parent reply other threads:[~2014-10-23 14:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 9:01 Richard Biener
2014-10-23 9:16 ` Jakub Jelinek
2014-10-23 12:51 ` Rainer Orth
2014-10-23 13:10 ` Richard Biener
2014-10-23 14:18 ` Richard Biener
2014-10-23 14:30 ` Richard Biener
2014-10-23 14:37 ` Richard Biener
2014-10-23 14:38 ` Richard Biener
2014-10-24 7:56 ` Rainer Orth
2014-10-24 8:07 ` Richard Biener
2014-10-24 9:51 ` Richard Biener
2014-10-24 11:04 ` Rainer Orth
2014-10-24 11:29 ` Richard Biener
2014-10-23 15:27 ` Jakub Jelinek [this message]
2014-10-23 21:35 ` Richard Sandiford
2014-10-24 8:00 ` Richard Biener
2014-10-24 4:32 ` PATCH: fix breakage from "[PATCH] Fix genmatch linking" Hans-Peter Nilsson
2014-10-24 5:02 ` Hans-Peter Nilsson
2014-10-24 8:03 ` Richard Biener
2014-10-24 17:04 ` Hans-Peter Nilsson
2014-10-25 8:57 ` Richard Biener
2014-10-29 0:22 ` Paolo Bonzini
2014-10-29 0:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023143811.GN10376@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).