From: DJ Delorie <dj@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: [msp430] fix X suffix
Date: Thu, 23 Oct 2014 19:10:00 -0000 [thread overview]
Message-ID: <201410231903.s9NJ3Y0t015479@greed.delorie.com> (raw)
Fixes BISX.A bug. Committed.
2014-10-23 DJ Delorie <dj@redhat.com>
* config/msp430/msp430.c (msp430_print_operand): 'x' modifier is
independend of -mlarge.
* config/msp430/constraints.md (Ys): Update comment.
Index: config/msp430/constraints.md
===================================================================
--- config/msp430/constraints.md (revision 216597)
+++ config/msp430/constraints.md (working copy)
@@ -55,13 +55,13 @@
(define_constraint "Yl"
"Memory reference, labels only."
(and (match_code "mem")
(match_code "label_ref" "0")))
-;; These are memory references that are safe to use with the X suffix,
+;; These are memory references that are safe to use without the X suffix,
;; because we know/assume they need not index across the 64k boundary.
(define_constraint "Ys"
"Memory reference, stack only."
(and (match_code "mem")
(ior
(and (match_code "plus" "0")
Index: config/msp430/msp430.c
===================================================================
--- config/msp430/msp430.c (revision 216597)
+++ config/msp430/msp430.c (working copy)
@@ -2604,13 +2604,13 @@ msp430_print_operand (FILE * file, rtx o
/* We don't care which operand we use, but we want 'X' in the MD
file, so we do it this way. */
return;
case 'x':
/* Similarly, but only for PSImodes. BIC, for example, needs this. */
- if (TARGET_LARGE && GET_MODE (op) == PSImode)
+ if (GET_MODE (op) == PSImode)
fprintf (file, "X");
return;
case 'Q':
/* Likewise, for BR -> BRA. */
if (TARGET_LARGE)
reply other threads:[~2014-10-23 19:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410231903.s9NJ3Y0t015479@greed.delorie.com \
--to=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).