From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13464 invoked by alias); 24 Oct 2014 14:03:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13453 invoked by uid 89); 24 Oct 2014 14:03:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Oct 2014 14:03:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9OE2wr5006812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Oct 2014 10:02:59 -0400 Received: from tucnak.zalov.cz (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9OE2uYo024450 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 24 Oct 2014 10:02:58 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id s9OE2s6K005300; Fri, 24 Oct 2014 16:02:55 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id s9OE2p79005299; Fri, 24 Oct 2014 16:02:51 +0200 Date: Fri, 24 Oct 2014 14:09:00 -0000 From: Jakub Jelinek To: Yury Gribov , Ian Lance Taylor Cc: GCC Patches , Konstantin Serebryany , Dmitry Vyukov , Andrey Ryabinin Subject: Re: [PATCHv5][Kasan] Allow to override Asan shadow offset from command line Message-ID: <20141024140251.GC10376@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <540DBD37.9060702@samsung.com> <5416B566.2000601@samsung.com> <5429951B.90900@samsung.com> <5440CADD.6060100@samsung.com> <544A5A95.6030502@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <544A5A95.6030502@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg02556.txt.bz2 On Fri, Oct 24, 2014 at 05:56:37PM +0400, Yury Gribov wrote: > >From 1882c41de6c8ae53b7e199b3cc655b6f4b31e8fb Mon Sep 17 00:00:00 2001 > From: Yury Gribov > Date: Thu, 16 Oct 2014 18:31:10 +0400 > Subject: [PATCH 1/2] Add strtoll and strtoull to libiberty. > > 2014-10-20 Yury Gribov > > include/ > * libiberty.h (strtol, strtoul, strtoll, strtoull): New prototypes. > > libiberty/ > * strtoll.c: New file. > * strtoull.c: New file. > * configure.ac: Add long long checks. Add harness for strtoll and > strtoull. Check decls for strtol, strtoul, strtoll, strtoull. > * Makefile.in (CFILES, CONFIGURED_OFILES): Added strtoll and strtoull. > * config.in: Regenerate. > * configure: Regenerate. > * functions.texi: Regenerate. > * testsuite/Makefile.in (check-strtol): New rule. > (test-strtol): Likewise. > (mostlyclean): Clean up strtol test. > * testsuite/test-strtol.c: New test. Ian, can you please review this? > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -883,6 +883,10 @@ fsanitize= > Common Driver Report Joined > Select what to sanitize > > +fasan-shadow-offset= > +Common Joined RejectNegative Var(common_deferred_options) Defer > +-fasan-shadow-offset= Use custom shadow memory offset. Shouldn't that be = or =
instead of string? > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -297,7 +297,7 @@ Objective-C and Objective-C++ Dialects}. > @xref{Debugging Options,,Options for Debugging Your Program or GCC}. > @gccoptlist{-d@var{letters} -dumpspecs -dumpmachine -dumpversion @gol > -fsanitize=@var{style} -fsanitize-recover -fsanitize-recover=@var{style} @gol > --fsanitize-undefined-trap-on-error @gol > +-fasan-shadow-offset=@var{string} -fsanitize-undefined-trap-on-error @gol Likewise here, @var{number} instead. > -fdbg-cnt-list -fdbg-cnt=@var{counter-value-list} @gol > -fdisable-ipa-@var{pass_name} @gol > -fdisable-rtl-@var{pass_name} @gol > @@ -5642,6 +5642,12 @@ While @option{-ftrapv} causes traps for signed overflows to be emitted, > @option{-fsanitize=undefined} gives a diagnostic message. > This currently works only for the C family of languages. > > +@item -fasan-shadow-offset=@var{string} And here. Otherwise looks good to me. Jakub