From: Jakub Jelinek <jakub@redhat.com>
To: Yury Gribov <y.gribov@samsung.com>
Cc: Maxim Ostapenko <m.ostapenko@partner.samsung.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Maxim Ostapenko <chefmax7@gmail.com>
Subject: Re: [PATCHv2] Don't expand string/memory builtins if ASan is enabled.
Date: Mon, 27 Oct 2014 14:37:00 -0000 [thread overview]
Message-ID: <20141027143458.GW10376@tucnak.redhat.com> (raw)
In-Reply-To: <5448BBC8.9060807@samsung.com>
On Thu, Oct 23, 2014 at 12:26:48PM +0400, Yury Gribov wrote:
> On 10/21/2014 05:26 PM, Maxim Ostapenko wrote:
> >Hi,
> >
> >this is the second version of the patch. Here the major changes from the
> >previous one:
>
> [snip]
>
> > case BUILT_IN_BCMP:
> >+ *intercepted_p = false;
>
> The code which identifies interceptors seems to be duplicated in
> expand_builtin. What about factoring this out to some is_asan_intercepted()
> in asan.h?
I agree.
BTW, when you handle a builtin, but set *intercepted_p to false, is the
point just that you don't instrument e.g. scalar accesses to that memory
region afterwards? I mean:
memcpy (p, "abc", 3);
p[0] = 'd';
you don't really have to instrument p[0] store, because supposedly memcpy
call has already verified p[0] through p[2] is writable.
Jakub
next prev parent reply other threads:[~2014-10-27 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5441008A.2010706@partner.samsung.com>
2014-10-17 11:47 ` [PATCH] " Maxim Ostapenko
2014-10-17 12:29 ` Jakub Jelinek
2014-10-17 13:03 ` Yury Gribov
2014-10-17 13:08 ` Jakub Jelinek
2014-10-21 13:38 ` [PATCHv2] " Maxim Ostapenko
2014-10-23 8:51 ` Yury Gribov
2014-10-27 14:37 ` Jakub Jelinek [this message]
2014-10-28 9:27 ` Maxim Ostapenko
2014-10-28 9:35 ` Jakub Jelinek
2014-11-11 23:51 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027143458.GW10376@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=chefmax7@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=m.ostapenko@partner.samsung.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).