From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21689 invoked by alias); 30 Oct 2014 08:52:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21680 invoked by uid 89); 30 Oct 2014 08:52:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 30 Oct 2014 08:52:08 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9U8q5mj013313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Oct 2014 04:52:06 -0400 Received: from tucnak.zalov.cz (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9U8q3Gg008531 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 30 Oct 2014 04:52:05 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id s9U8q19q020423; Thu, 30 Oct 2014 09:52:01 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id s9U8pxFP020417; Thu, 30 Oct 2014 09:51:59 +0100 Date: Thu, 30 Oct 2014 08:56:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" , Tom Tromey , Jeff Law , Phil Muldoon Subject: Re: [PATCH 5/5] add libcc1 Message-ID: <20141030085159.GX10376@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20141028093506.GE10376@tucnak.redhat.com> <544F7181.4060307@redhat.com> <544F8253.4040906@redhat.com> <20141028122350.GF10376@tucnak.redhat.com> <87y4rydkjf.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y4rydkjf.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg03184.txt.bz2 On Thu, Oct 30, 2014 at 09:33:08AM +0100, Thomas Schwinge wrote: > Here is a patch that I'm testing; OK? I didn't understand what the > conditions are that libcc1 might not be built as a shared library: is it > always built as one -- but is that really supported on all systems? If It is not unconditionally supported, libcc1/configure.ac uses GCC_ENABLE_PLUGINS and doesn't compile anything if gcc doesn't support plugins (one of the several tests of that is that -fPIC -shared is supported. > that's indeed true, then this could be further simplified, and > --enable-shared passed to the host libiberty unconditionally. Your patch is ok with proper ChangeLog entry. > --- configure.ac > +++ configure.ac > @@ -1865,7 +1865,6 @@ if test -d ${srcdir}/gcc; then > new_enable_languages=,c, > > # If LTO is enabled, add the LTO front end. > - extra_host_libiberty_configure_flags= > if test "$enable_lto" = "yes" ; then > case ,${enable_languages}, in > *,lto,*) ;; > @@ -1873,10 +1872,8 @@ if test -d ${srcdir}/gcc; then > esac > if test "${build_lto_plugin}" = "yes" ; then > configdirs="$configdirs lto-plugin" > - extra_host_libiberty_configure_flags=--enable-shared > fi > fi > - AC_SUBST(extra_host_libiberty_configure_flags) > > missing_languages=`echo ",$enable_languages," | sed -e s/,all,/,/ -e s/,c,/,/ ` > potential_languages=,c, > @@ -2190,6 +2187,17 @@ then > esac > fi > > +# Sometimes we have special requirements for the host libiberty. > +extra_host_libiberty_configure_flags= > +case " $configdirs " in > + *" lto-plugin "* | *" libcc1 "*) > + # When these are to be built as shared libraries, the same applies to > + # libiberty. > + extra_host_libiberty_configure_flags=--enable-shared > + ;; > +esac > +AC_SUBST(extra_host_libiberty_configure_flags) > + > # Produce a warning message for the subdirs we can't configure. > # This isn't especially interesting in the Cygnus tree, but in the individual > # FSF releases, it's important to let people know when their machine isn't > > > Grüße, > Thomas Jakub