public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: "Zamyatin, Igor" <igor.zamyatin@intel.com>
Cc: Jeff Law <law@redhat.com>,
	Evgeny Stupachenko <evstupac@gmail.com>,
	       Andrew Pinski <pinskia@gmail.com>,
	Uros Bizjak <ubizjak@gmail.com>,
	       Vladimir Makarov <vmakarov@redhat.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/X, i386, PR54232] Enable EBX for x86 in 32bits PIC code
Date: Thu, 30 Oct 2014 13:19:00 -0000	[thread overview]
Message-ID: <20141030131604.GE10376@tucnak.redhat.com> (raw)
In-Reply-To: <0EFAB2BDD0F67E4FB6CCC8B9F87D756969C1489D@IRSMSX101.ger.corp.intel.com>

On Thu, Oct 30, 2014 at 12:34:45PM +0000, Zamyatin, Igor wrote:
> > 
> > On Thu, Oct 30, 2014 at 08:48:57AM +0000, Zamyatin, Igor wrote:
> > > Posted a patch in libc-alpha:
> > >
> > > https://sourceware.org/ml/libc-alpha/2014-10/msg00701.html
> > 
> > That looks wrong.  The non-PIC patterns that are enabled unconditionally
> > with the patch set/use ebx, which will not work with pre-GCC 5 in PIC mode.
> 
> Could you please specify why do you think it is wrong for PIC mode for pre-GCC 5?

Those macros use "=&b" etc. in asm constraints, so IMHO you'll get the same
error as for say:

int
foo (void)
{
  bar ();
  int i = 0;
  asm volatile ("" : "+b" (i));
  bar ();
  return i;
}

when compiled by gcc 4.9 and earlier with -O2 -m32 -fpic:
error: inconsistent operand constraints in an ‘asm’

	Jakub

  reply	other threads:[~2014-10-30 13:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  7:54 Evgeny Stupachenko
2014-10-10 10:41 ` Uros Bizjak
2014-10-10 12:34 ` Uros Bizjak
2014-10-10 12:37   ` Rainer Orth
2014-10-10 12:38     ` Jakub Jelinek
2014-10-10 14:09       ` Evgeny Stupachenko
2014-10-13 15:03         ` Evgeny Stupachenko
2014-10-13 16:10           ` Uros Bizjak
2014-10-24 23:21 ` Andrew Pinski
2014-10-24 23:38   ` Evgeny Stupachenko
2014-10-24 23:48     ` Jeff Law
2014-10-30  8:52       ` Zamyatin, Igor
2014-10-30  9:13         ` Jakub Jelinek
2014-10-30 13:09           ` Zamyatin, Igor
2014-10-30 13:19             ` Jakub Jelinek [this message]
2014-10-31 10:06               ` Zamyatin, Igor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030131604.GE10376@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=evstupac@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=igor.zamyatin@intel.com \
    --cc=law@redhat.com \
    --cc=pinskia@gmail.com \
    --cc=ubizjak@gmail.com \
    --cc=vmakarov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).