From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6519 invoked by alias); 30 Oct 2014 13:16:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6507 invoked by uid 89); 30 Oct 2014 13:16:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 30 Oct 2014 13:16:12 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9UDG96g026340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Oct 2014 09:16:10 -0400 Received: from tucnak.zalov.cz (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9UDG7Ij024487 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 30 Oct 2014 09:16:08 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id s9UDG69h028711; Thu, 30 Oct 2014 14:16:06 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id s9UDG4Vh028710; Thu, 30 Oct 2014 14:16:04 +0100 Date: Thu, 30 Oct 2014 13:19:00 -0000 From: Jakub Jelinek To: "Zamyatin, Igor" Cc: Jeff Law , Evgeny Stupachenko , Andrew Pinski , Uros Bizjak , Vladimir Makarov , GCC Patches Subject: Re: [PATCH 2/X, i386, PR54232] Enable EBX for x86 in 32bits PIC code Message-ID: <20141030131604.GE10376@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <544AE3BE.80606@redhat.com> <0EFAB2BDD0F67E4FB6CCC8B9F87D756969C138B1@IRSMSX101.ger.corp.intel.com> <20141030085610.GY10376@tucnak.redhat.com> <0EFAB2BDD0F67E4FB6CCC8B9F87D756969C1489D@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0EFAB2BDD0F67E4FB6CCC8B9F87D756969C1489D@IRSMSX101.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg03205.txt.bz2 On Thu, Oct 30, 2014 at 12:34:45PM +0000, Zamyatin, Igor wrote: > > > > On Thu, Oct 30, 2014 at 08:48:57AM +0000, Zamyatin, Igor wrote: > > > Posted a patch in libc-alpha: > > > > > > https://sourceware.org/ml/libc-alpha/2014-10/msg00701.html > > > > That looks wrong. The non-PIC patterns that are enabled unconditionally > > with the patch set/use ebx, which will not work with pre-GCC 5 in PIC mode. > > Could you please specify why do you think it is wrong for PIC mode for pre-GCC 5? Those macros use "=&b" etc. in asm constraints, so IMHO you'll get the same error as for say: int foo (void) { bar (); int i = 0; asm volatile ("" : "+b" (i)); bar (); return i; } when compiled by gcc 4.9 and earlier with -O2 -m32 -fpic: error: inconsistent operand constraints in an ‘asm’ Jakub