From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Ian Taylor <iant@golang.org>,
Joern Rennecke <joern.rennecke@embecosm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work)
Date: Thu, 30 Oct 2014 14:15:00 -0000 [thread overview]
Message-ID: <20141030131947.GF28215@lug-owl.de> (raw)
In-Reply-To: <CAOyqgcWBYbRGT4wjTvhv-8x273_u1-QOaqwYV0XJSxyPpkXjgQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3875 bytes --]
On Mon, 2014-10-27 09:33:41 -0700, Ian Taylor <iant@golang.org> wrote:
> On Mon, Oct 27, 2014 at 9:02 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> > On Mon, 2014-10-27 08:19:34 -0700, Ian Taylor <iant@golang.org> wrote:
> > > On Mon, Oct 27, 2014 at 8:06 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> > > > On Wed, 2014-10-22 20:36:53 -0700, Ian Taylor <iant@golang.org> wrote:
> > > > > This patch to the top level GCC configure script disables
> > > > > the go languages on some systems where it is known to not
> > > > > work. Bootstrapped on x86_64-unknown-gnu-linux.
> > With its initial commit in 2010, Joern had Go in the
> > --enable-languages list in contrib/config-list.mk . This used to
> > work (read: build succeeded), even if Go wouldn't work (or wasn't
> > built silently, I didn't check.)
> >
> > With this slight change in behavior, we'd probably fix
> > config-list.mk to reflect these targets where Go would lead to a
> > configury failure early.
>
> I think changing config-list.mk is appropriate.
This updates contrib/config-list.mk to build Go for all but
known-non-working targets. A comment to configure{.ac,} is also added.
Ok for mainline?
2014-10-30 Jan-Benedict Glaw <jbglaw@lug-owl.de>
./contrib
* config-list.mk: Don't build Go for certain targets.
./
* configure.ac: Update comment.
* configure: Regenerate.
diff --git a/contrib/config-list.mk b/contrib/config-list.mk
index 94884d9..16900e1 100644
--- a/contrib/config-list.mk
+++ b/contrib/config-list.mk
@@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS
$(LIST): make-log-dir
-mkdir $@
- (cd $@ && \
- ../../gcc/configure \
- --target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \
- --enable-werror-always ${host_options} --enable-languages=all,ada,go) \
- > log/$@-config.out 2>&1
+ ( \
+ cd $@ && \
+ echo $@ && \
+ TGT=`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` && \
+ TGT=`../../gcc/config.sub $$TGT` && \
+ case $$TGT in \
+ *-*-darwin* | *-*-cygwin* | *-*-mingw* | *-*-aix*) \
+ ADDITIONAL_LANGUAGES=""; \
+ ;; \
+ *) \
+ ADDITIONAL_LANGUAGES=",go"; \
+ ;; \
+ esac && \
+ ../../gcc/configure \
+ --target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \
+ --enable-werror-always ${host_options} \
+ --enable-languages=all,ada$$ADDITIONAL_LANGUAGES; \
+ ) > log/$@-config.out 2>&1
$(LOGFILES) : log/%-make.out : %
-$(MAKE) -C $< $(TEST) > $@ 2>&1 && rm -rf $<diff --git a/configure.ac b/configure.ac
index d8262f8..2f0af4a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -769,10 +769,11 @@ case "${target}" in
;;
*-*-lynxos*)
noconfigdirs="$noconfigdirs ${libgcj}"
- ;;
+ ;;
esac
-# Disable the go frontend on systems where it is known to not work.
+# Disable the go frontend on systems where it is known to not work. Please keep
+# this in sync with contrib/config-list.mk.
case "${target}" in
*-*-darwin* | *-*-cygwin* | *-*-mingw* | *-*-aix*)
unsupported_languages="$unsupported_languages go"
diff --git a/configure b/configure
index 3eab122..d0c760b 100755
--- a/configure
+++ b/configure
@@ -3413,7 +3413,8 @@ case "${target}" in
;;
esac
-# Disable the go frontend on systems where it is known to not work.
+# Disable the go frontend on systems where it is known to not work. Please keep
+# this in sync with contrib/config-list.mk.
case "${target}" in
*-*-darwin* | *-*-cygwin* | *-*-mingw* | *-*-aix*)
unsupported_languages="$unsupported_languages go"
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Träume nicht von Deinem Leben: Lebe Deinen Traum!
the second :
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-10-30 13:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 6:30 Patch RFA: Top-level configure patch: disable go on systems where it doesn't work Ian Taylor
2014-10-23 15:31 ` Pedro Alves
2014-10-23 15:35 ` Ian Taylor
2014-10-23 15:41 ` Pedro Alves
2014-10-23 18:27 ` Ian Taylor
2014-10-23 18:17 ` Jeff Law
2014-10-27 15:07 ` Jan-Benedict Glaw
2014-10-27 15:20 ` Ian Taylor
2014-10-27 16:03 ` Jan-Benedict Glaw
2014-10-27 16:57 ` Ian Taylor
2014-10-30 14:15 ` Jan-Benedict Glaw [this message]
2014-10-30 15:20 ` [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work) Ian Taylor
2014-10-30 19:43 ` Jan-Benedict Glaw
2014-10-31 0:44 ` Ian Taylor
2014-10-31 11:07 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030131947.GF28215@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
--cc=joern.rennecke@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).