From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11212 invoked by alias); 30 Oct 2014 13:19:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11133 invoked by uid 89); 30 Oct 2014 13:19:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: lug-owl.de Received: from lug-owl.de (HELO lug-owl.de) (195.71.106.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 30 Oct 2014 13:19:52 +0000 Received: by lug-owl.de (Postfix, from userid 1001) id 09001F024D; Thu, 30 Oct 2014 14:19:47 +0100 (CET) Date: Thu, 30 Oct 2014 14:15:00 -0000 From: Jan-Benedict Glaw To: Ian Taylor , Joern Rennecke Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work) Message-ID: <20141030131947.GF28215@lug-owl.de> References: <20141027150658.GZ28215@lug-owl.de> <20141027160244.GA28215@lug-owl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DEfZqDS1MPR2ysog" Content-Disposition: inline In-Reply-To: X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg03207.txt.bz2 --DEfZqDS1MPR2ysog Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 3824 On Mon, 2014-10-27 09:33:41 -0700, Ian Taylor wrote: > On Mon, Oct 27, 2014 at 9:02 AM, Jan-Benedict Glaw wr= ote: > > On Mon, 2014-10-27 08:19:34 -0700, Ian Taylor wrote: > > > On Mon, Oct 27, 2014 at 8:06 AM, Jan-Benedict Glaw wrote: > > > > On Wed, 2014-10-22 20:36:53 -0700, Ian Taylor wro= te: > > > > > This patch to the top level GCC configure script disables > > > > > the go languages on some systems where it is known to not > > > > > work. Bootstrapped on x86_64-unknown-gnu-linux. > > With its initial commit in 2010, Joern had Go in the > > --enable-languages list in contrib/config-list.mk . This used to > > work (read: build succeeded), even if Go wouldn't work (or wasn't > > built silently, I didn't check.) > > > > With this slight change in behavior, we'd probably fix > > config-list.mk to reflect these targets where Go would lead to a > > configury failure early. >=20 > I think changing config-list.mk is appropriate. This updates contrib/config-list.mk to build Go for all but known-non-working targets. A comment to configure{.ac,} is also added. Ok for mainline? 2014-10-30 Jan-Benedict Glaw ./contrib * config-list.mk: Don't build Go for certain targets. ./ * configure.ac: Update comment. * configure: Regenerate. diff --git a/contrib/config-list.mk b/contrib/config-list.mk index 94884d9..16900e1 100644 --- a/contrib/config-list.mk +++ b/contrib/config-list.mk @@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS =20 $(LIST): make-log-dir -mkdir $@ - (cd $@ && \ - ../../gcc/configure \ - --target=3D$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \ - --enable-werror-always ${host_options} --enable-languages=3Dall,ada,go) \ - > log/$@-config.out 2>&1 + ( \ + cd $@ && \ + echo $@ && \ + TGT=3D`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` && \ + TGT=3D`../../gcc/config.sub $$TGT` && \ + case $$TGT in \ + *-*-darwin* | *-*-cygwin* | *-*-mingw* | *-*-aix*) \ + ADDITIONAL_LANGUAGES=3D""; \ + ;; \ + *) \ + ADDITIONAL_LANGUAGES=3D",go"; \ + ;; \ + esac && \ + ../../gcc/configure \ + --target=3D$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)= ) \ + --enable-werror-always ${host_options} \ + --enable-languages=3Dall,ada$$ADDITIONAL_LANGUAGES; \ + ) > log/$@-config.out 2>&1 =20 $(LOGFILES) : log/%-make.out : % -$(MAKE) -C $< $(TEST) > $@ 2>&1 && rm -rf $