From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 736 invoked by alias); 30 Oct 2014 19:15:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 717 invoked by uid 89); 30 Oct 2014 19:15:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: lug-owl.de Received: from lug-owl.de (HELO lug-owl.de) (195.71.106.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 30 Oct 2014 19:15:02 +0000 Received: by lug-owl.de (Postfix, from userid 1001) id 4D9C0F024C; Thu, 30 Oct 2014 20:14:58 +0100 (CET) Date: Thu, 30 Oct 2014 19:43:00 -0000 From: Jan-Benedict Glaw To: Ian Taylor Cc: Joern Rennecke , gcc-patches Subject: Re: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work) Message-ID: <20141030191457.GG28215@lug-owl.de> References: <20141027150658.GZ28215@lug-owl.de> <20141027160244.GA28215@lug-owl.de> <20141030131947.GF28215@lug-owl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fTrra2YUagINO7SV" Content-Disposition: inline In-Reply-To: X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg03233.txt.bz2 --fTrra2YUagINO7SV Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2111 On Thu, 2014-10-30 08:08:51 -0700, Ian Taylor wrote: > On Thu, Oct 30, 2014 at 6:19 AM, Jan-Benedict Glaw wr= ote: > > > > This updates contrib/config-list.mk to build Go for all but > > known-non-working targets. A comment to configure{.ac,} is also added. >=20 > > diff --git a/contrib/config-list.mk b/contrib/config-list.mk > > index 94884d9..16900e1 100644 > > --- a/contrib/config-list.mk > > +++ b/contrib/config-list.mk > > @@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS > > > > $(LIST): make-log-dir > > -mkdir $@ > > - (cd $@ && \ > > - ../../gcc/configure \ > > - --target=3D$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empt= y) -,$@)) \ > > - --enable-werror-always ${host_options} --enable-languages=3Dall= ,ada,go) \ > > - > log/$@-config.out 2>&1 > > + ( = \ > > + cd $@ && = \ > > + echo $@ && = \ > > + TGT=3D`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` && = \ > > + TGT=3D`../../gcc/config.sub $$TGT` && = \ >=20 > This isn't necessary. The OPT bits will be matched by the * at the > end of the cases anyhow. You can just write > case $@ in >=20 > This is OK with that change. Not exactly: My intention was to keep the triplet matches as they show up in configure.ac . However, the target list in config-list.mk uses (almost exclusively) shorthands for all the targets, so these need to be expand (--> config.sub); that however won't really fly with the OPTs in there. MfG, JBG --=20 Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: God put me on earth to accomplish a certain numbe= r of the second : things. Right now I am so far behind I will never = die. --fTrra2YUagINO7SV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 198 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlRSjjEACgkQHb1edYOZ4bvaYACeK1QWMuIOn+9XxD4ENnrMFN5p R3IAn3/2nR2hStqqeEAIgt7PWpDLHEsE =y2oy -----END PGP SIGNATURE----- --fTrra2YUagINO7SV--