From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10718 invoked by alias); 12 Nov 2014 09:07:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10709 invoked by uid 89); 12 Nov 2014 09:07:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Nov 2014 09:07:53 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAC97qP0013039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Nov 2014 04:07:52 -0500 Received: from tucnak.zalov.cz (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAC97okG019318 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 12 Nov 2014 04:07:51 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id sAC97ma2024221; Wed, 12 Nov 2014 10:07:49 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id sAC97lO7024218; Wed, 12 Nov 2014 10:07:47 +0100 Date: Wed, 12 Nov 2014 09:18:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: gcc-patches@gcc.gnu.org, Kirill Yukhin , Andrey Turetskiy Subject: Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing Message-ID: <20141112090747.GO5026@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20141021171323.GA47586@msticlxl57.ims.intel.com> <20141030114001.GA34120@msticlxl57.ims.intel.com> <20141106175540.GN5026@tucnak.redhat.com> <20141110143430.GB50497@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141110143430.GB50497@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg01140.txt.bz2 On Mon, Nov 10, 2014 at 05:34:30PM +0300, Ilya Verbin wrote: > > I don't like this, that is too fragile. If automake is changed, we'll > > forget to update this. > > If all you are about are the 3 additional variables, can't you instead > > put them into env vars and query them in the tcl code using getenv? > > Or append them into AM_RUNTESTFLAGS ? > > AM_RUNTESTFLAGS += @something@ > > Done, I put them into env vars. Thanks. > > > + lappend ALWAYS_CFLAGS "additional_flags=${offload_additional_options}" > > > } > > > > Perhaps add this only if offload_additional_options is non-empty? > > Done. Ok for trunk. Jakub