From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12809 invoked by alias); 12 Nov 2014 13:29:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12798 invoked by uid 89); 12 Nov 2014 13:29:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Nov 2014 13:29:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sACDTHIh032574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Nov 2014 08:29:18 -0500 Received: from tucnak.zalov.cz (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sACDTFKi000492 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 12 Nov 2014 08:29:17 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id sACDTEdf021125; Wed, 12 Nov 2014 14:29:14 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id sACDTDwn021124; Wed, 12 Nov 2014 14:29:13 +0100 Date: Wed, 12 Nov 2014 13:29:00 -0000 From: Jakub Jelinek To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Subject: Re: PATCH GCC5.0: conditionally skip gcc_version in plugin-version.h Message-ID: <20141112132913.GB5026@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20141112125512.GA26644@ovh.starynkevitch.net> <20141112131207.GY5026@tucnak.redhat.com> <20141112132022.GA26839@ovh.starynkevitch.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141112132022.GA26839@ovh.starynkevitch.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg01204.txt.bz2 On Wed, Nov 12, 2014 at 02:20:22PM +0100, Basile Starynkevitch wrote: > Most plugin don't need any configure, because they are installed in > a version specific directory (like /usr/lib/gcc/x86_64-linux-gnu/4.9/plugin > for example). I don't think it is wise to require plugin to be > autoconf-configurable. Their Makefile simply uses > $(shell gcc -print-file-name=plugin), there is no need to complex > autoconf machinery. If you use $(shell gcc -print-file-name=plugin), there is no point to include plugin-version.h, just use __GNUC__/__GNUC_MINOR__ ? Jakub