public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Basile Starynkevitch <basile@starynkevitch.net>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Basile Starynkevitch <basile@starynkevitch.net>,	gcc-patches@gcc.gnu.org
Subject: Re: PATCH GCC5.0: conditionally skip gcc_version in plugin-version.h
Date: Wed, 12 Nov 2014 13:38:00 -0000	[thread overview]
Message-ID: <20141112133646.GA26947@ovh.starynkevitch.net> (raw)
In-Reply-To: <20141112132913.GB5026@tucnak.redhat.com>

On Wed, Nov 12, 2014 at 02:29:13PM +0100, Jakub Jelinek wrote:
> On Wed, Nov 12, 2014 at 02:20:22PM +0100, Basile Starynkevitch wrote:
> > Most plugin don't need any configure, because they are installed in 
> > a version specific directory (like /usr/lib/gcc/x86_64-linux-gnu/4.9/plugin 
> > for example). I don't think it is wise to require plugin to be 
> > autoconf-configurable. Their Makefile simply uses 
> > $(shell gcc -print-file-name=plugin), there is no need to complex
> > autoconf machinery.
> 
> If you use $(shell gcc -print-file-name=plugin), there is no point
> to include plugin-version.h, just use __GNUC__/__GNUC_MINOR__ ?


I could compile a plugin (notably for a GCC cross-compiler) with a GCC version
different of the GCC targetting the plugin. I could also compile a 
plugin with Clang or some other non-GCC compiler. In both cases
plugin-version.h is needed with its GCCPLUGIN_VERSION.

Cheers.

--
Basile Starynkevitch     http://starynkevitch.net/Basile/

  reply	other threads:[~2014-11-12 13:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 13:07 PATCH GCC5.0: conditionally skip gcc_version in gcc-plugin.h Basile Starynkevitch
2014-11-12 13:14 ` Jakub Jelinek
2014-11-12 13:20   ` PATCH GCC5.0: conditionally skip gcc_version in plugin-version.h Basile Starynkevitch
2014-11-12 13:29     ` Jakub Jelinek
2014-11-12 13:38       ` Basile Starynkevitch [this message]
2014-11-13  6:53         ` Basile Starynkevitch
2014-11-12 14:37   ` PATCH GCC5.0: conditionally skip gcc_version in gcc-plugin.h Richard Biener
2014-11-12 14:38     ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141112133646.GA26947@ovh.starynkevitch.net \
    --to=basile@starynkevitch.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).