Re: [PATCH 4/5] OpenACC 2.0 support for libgomp - new tests (repost)

[Jakub Jelinek <jakub@redhat.com>]

On Tue, Nov 11, 2014 at 01:54:42PM +0000, Julian Brown wrote:
> @@ -169,6 +192,57 @@ proc libgomp_init { args } {
>  
>      # Disable color diagnostics
>      lappend ALWAYS_CFLAGS "additional_flags=-fdiagnostics-color=never"
> +
> +    # TODO.  Evil hack.  DejaGnu doesn't have a mechanism for setting
> +    # environment variables on remote boards.  Thus, we have to fake it, using
> +    # GCC's constructor attributes to create object files that install the
> +    # desired environment variables.

...

Please don't add ugly hacks, I thought Thomas said you didn't mean to put
this in.

> +global shlib_ext
> +
> +set shlib_ext [get_shlib_extension]
> +#TODO

???

> +# Turn on OpenACC.
> +# XXX (TEMPORARY): Remove the -flto once that's properly integrated.
> +lappend ALWAYS_CFLAGS "additional_flags=-fopenacc -flto"

Do you still need that?

> +    # Todo: get list of accelerators from configure options --enable-accelerator.
> +    set accels { "nvidia" "host_nonshm" }

I hope intelmicemul and intelmic will be added here soon.

> +	# Todo: Determine shared memory or not using run-time test.

Please just do that using the run-time test.

	Jakub