public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [gomp4 3/6] Initial support for OpenACC memory mapping semantics.
Date: Thu, 13 Nov 2014 13:13:00 -0000	[thread overview]
Message-ID: <20141113131010.GO5026@tucnak.redhat.com> (raw)
In-Reply-To: <87fvdncmxg.fsf@kepler.schwinge.homeip.net>

On Thu, Nov 13, 2014 at 01:19:55PM +0100, Thomas Schwinge wrote:
> --- include/gomp-constants.h
> +++ include/gomp-constants.h
> @@ -28,6 +28,9 @@
>  /* Enumerated variable mapping types used to communicate between GCC and
>     libgomp.  These values are used for both OpenMP and OpenACC.  */
>  
> +#define _GOMP_MAP_FLAG_SPECIAL		(1 << 2)
> +#define _GOMP_MAP_FLAG_FORCE		(1 << 3)

I'm worried about reserved namespace issues if you use _ followed by
capital letter.  Can't it be just GOMP_MAP_FLAG_* ?

	Jakub

  reply	other threads:[~2014-11-13 13:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 15:09 [gomp4] Initial support for OpenACC data clauses Thomas Schwinge
2014-01-14 15:10 ` [gomp4 1/6] During gimplification, allow additional flags next to ORT_TARGET thomas
2014-01-14 15:10   ` [gomp4 2/6] Prepare for extending omp_clause_map_kind thomas
2014-01-14 15:10     ` [gomp4 3/6] Initial support for OpenACC memory mapping semantics thomas
2014-01-14 15:10       ` [gomp4 4/6] C front end infrastructure for OpenACC clauses parsing thomas
2014-01-14 15:10         ` [gomp4 5/6] Initial support in the C front end for OpenACC data clauses thomas
2014-01-14 15:10           ` [gomp4 6/6] Enable initial " thomas
2014-02-12 11:17           ` [gomp4 5/6] Initial " Thomas Schwinge
2014-02-21 19:48       ` [gomp4 3/6] Initial support for OpenACC memory mapping semantics Thomas Schwinge
2014-02-21 20:32         ` [gomp4 1/3] Clarify to/from/map clauses usage in context of GF_OMP_TARGET_KIND_UPDATE Thomas Schwinge
2014-02-21 20:32           ` [gomp4 2/3] OpenACC data construct implementation in terms of GF_OMP_TARGET_KIND_OACC_DATA Thomas Schwinge
2014-02-21 20:32             ` [gomp4 3/3] OpenACC data construct support in the C front end Thomas Schwinge
2014-03-12 13:48             ` [gomp4 2/3] OpenACC data construct implementation in terms of GF_OMP_TARGET_KIND_OACC_DATA Thomas Schwinge
2014-03-20 14:39             ` [gomp4] Nesting of OpenACC constructs inside of OpenACC data constructs (was: [gomp4 2/3] OpenACC data construct implementation in terms of GF_OMP_TARGET_KIND_OACC_DATA.) Thomas Schwinge
     [not found]       ` <538DF785.3050206@mentor.com>
     [not found]         ` <87egz645j4.fsf@schwinge.name>
2014-11-13 12:21           ` [gomp4 3/6] Initial support for OpenACC memory mapping semantics Thomas Schwinge
2014-11-13 13:13             ` Jakub Jelinek [this message]
2014-11-13 13:39               ` gomp-constants.h (was: [gomp4 3/6] Initial support for OpenACC memory mapping semantics.) Thomas Schwinge
2014-11-13 13:57                 ` Jakub Jelinek
2014-01-28  9:44 ` [gomp4] Initial support for OpenACC data clauses Thomas Schwinge
2014-06-05 14:00 ` [GOMP4, COMMITTED] OpenACC present data clause Thomas Schwinge
2014-06-05 14:00 ` [GOMP4, COMMITTED] OpenACC deviceptr clause Thomas Schwinge
     [not found]   ` <5460F49F.3040904@mentor.com>
2014-11-11 21:30     ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141113131010.GO5026@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).