From: Ilya Verbin <iverbin@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches@gcc.gnu.org, Bernd Schmidt <bernds@codesourcery.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [PATCH 6/n] OpenMP 4.0 offloading infrastructure: option handling
Date: Tue, 09 Dec 2014 22:48:00 -0000 [thread overview]
Message-ID: <20141209224821.GB32616@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1412091459110.8254@zhemvz.fhfr.qr>
On 09 Dec 14:59, Richard Biener wrote:
> On Mon, 8 Dec 2014, Ilya Verbin wrote:
> > Unfortunately, this fix was not general enough.
> > There might be cases when mixed object files get into lto-wrapper, ie some of
> > them contain only LTO sections, some contain only offload sections, and some
> > contain both. But when lto-wrapper will pass all these files to recompilation,
> > the compiler might crash (it depends on the order of input files), since in
> > read_cgraph_and_symbols it expects that *all* input files contain IR section of
> > given type.
> > This patch splits input objects from argv into lto_argv and offload_argv, so
> > that all files in arrays contain corresponding IR.
> > Similarly, in lto-plugin, it was bad idea to add objects, which contain offload
> > IR without LTO, to claimed_files, since this may corrupt a resolution file.
> >
> > Tested on various combinations of files with/without -flto and with/without
> > offload, using trunk ld and gold, also tested on ld without plugin support.
> > Bootstrap and make check passed on x86_64-linux and i686-linux. Ok for trunk?
>
> Did you check that bootstrap-lto still works? Ok if so.
Yes, bootstrap-lto passed.
Committed revision 218543.
Thanks,
-- Ilya
next prev parent reply other threads:[~2014-12-09 22:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 14:59 Ilya Verbin
2014-10-13 10:27 ` Jakub Jelinek
2014-10-13 10:36 ` Ilya Verbin
2014-10-13 15:08 ` Bernd Schmidt
2014-10-14 7:31 ` Richard Biener
2014-10-14 12:58 ` Bernd Schmidt
2014-10-15 14:12 ` Richard Biener
2014-10-27 10:59 ` Bernd Schmidt
2015-02-18 17:04 ` Thomas Schwinge
2015-02-19 9:28 ` Thomas Schwinge
2015-03-10 12:37 ` Thomas Schwinge
2015-04-27 16:08 ` Thomas Schwinge
2015-04-28 13:39 ` Bernd Schmidt
2015-04-29 16:41 ` Thomas Schwinge
2015-07-14 20:10 ` Thomas Schwinge
2015-07-14 20:15 ` Richard Biener
2014-10-24 18:33 ` Ilya Verbin
2014-10-24 18:41 ` Jakub Jelinek
2014-10-27 12:06 ` Ilya Verbin
2014-11-28 1:45 ` Ilya Verbin
2014-11-28 9:32 ` Richard Biener
2014-12-07 23:55 ` Ilya Verbin
2014-12-09 14:06 ` Richard Biener
2014-12-09 22:48 ` Ilya Verbin [this message]
2015-11-20 19:34 ` Ilya Verbin
2015-11-23 11:09 ` Richard Biener
2015-09-21 15:51 ` Thomas Schwinge
2015-09-21 16:59 ` Ilya Verbin
2015-09-22 12:20 ` Thomas Schwinge
2015-09-22 23:03 ` Bernd Schmidt
2015-09-23 15:19 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209224821.GB32616@msticlxl57.ims.intel.com \
--to=iverbin@gmail.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).